From patchwork Wed May 13 15:29:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Doucha X-Patchwork-Id: 1289405 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49MdrP3RfVz9sRY for ; Thu, 14 May 2020 01:29:24 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id BF7DB3C54DE for ; Wed, 13 May 2020 17:29:20 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) by picard.linux.it (Postfix) with ESMTP id 3FF783C23BF for ; Wed, 13 May 2020 17:29:17 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 3F27560103F for ; Wed, 13 May 2020 17:28:57 +0200 (CEST) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A07FB00E for ; Wed, 13 May 2020 15:29:19 +0000 (UTC) From: Martin Doucha To: ltp@lists.linux.it Date: Wed, 13 May 2020 17:29:14 +0200 Message-Id: <20200513152914.2703-1-mdoucha@suse.cz> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-5.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=7.0 tests=SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-5.smtp.seeweb.it Subject: [LTP] [PATCH] Add missing mode argument to open(..., O_CREAT) X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Signed-off-by: Martin Doucha Reviewed-by: Petr Vorel --- testcases/kernel/syscalls/fallocate/fallocate05.c | 5 +++-- testcases/kernel/syscalls/fallocate/fallocate06.c | 4 ++-- testcases/kernel/syscalls/getdents/getdents02.c | 2 +- testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c | 2 +- testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c | 2 +- testcases/kernel/syscalls/kcmp/kcmp01.c | 2 +- testcases/kernel/syscalls/kcmp/kcmp02.c | 4 ++-- testcases/kernel/syscalls/msync/msync04.c | 3 ++- testcases/kernel/syscalls/tee/tee02.c | 2 +- 9 files changed, 14 insertions(+), 12 deletions(-) diff --git a/testcases/kernel/syscalls/fallocate/fallocate05.c b/testcases/kernel/syscalls/fallocate/fallocate05.c index 550d10258..55ec1aee4 100644 --- a/testcases/kernel/syscalls/fallocate/fallocate05.c +++ b/testcases/kernel/syscalls/fallocate/fallocate05.c @@ -39,7 +39,7 @@ static void setup(void) int fd; struct stat statbuf; - fd = SAFE_OPEN(MNTPOINT "/test_file", O_WRONLY | O_CREAT); + fd = SAFE_OPEN(MNTPOINT "/test_file", O_WRONLY | O_CREAT, 0644); /* * Use real FS block size, otherwise fallocate() call will test @@ -57,7 +57,8 @@ static void run(void) int fd; long extsize, tmp; - fd = SAFE_OPEN(MNTPOINT "/test_file", O_WRONLY | O_CREAT | O_TRUNC); + fd = SAFE_OPEN(MNTPOINT "/test_file", O_WRONLY | O_CREAT | O_TRUNC, + 0644); TEST(fallocate(fd, 0, 0, bufsize)); if (TST_RET) { diff --git a/testcases/kernel/syscalls/fallocate/fallocate06.c b/testcases/kernel/syscalls/fallocate/fallocate06.c index 272edf161..409fd1321 100644 --- a/testcases/kernel/syscalls/fallocate/fallocate06.c +++ b/testcases/kernel/syscalls/fallocate/fallocate06.c @@ -77,7 +77,7 @@ static void setup(void) int fd; struct stat statbuf; - fd = SAFE_OPEN(TEMPFILE, O_WRONLY | O_CREAT | O_TRUNC); + fd = SAFE_OPEN(TEMPFILE, O_WRONLY | O_CREAT | O_TRUNC, 0644); /* * Set FS_NOCOW_FL flag on the temp file. Non-CoW filesystems will @@ -166,7 +166,7 @@ static void run(unsigned int n) tst_res(TINFO, "Case %u. Fill FS: %s; Use copy on write: %s", n+1, tc->fill_fs ? "yes" : "no", tc->no_cow ? "no" : "yes"); - fd = SAFE_OPEN(TEMPFILE, O_RDWR | O_CREAT | O_TRUNC); + fd = SAFE_OPEN(TEMPFILE, O_RDWR | O_CREAT | O_TRUNC, 0644); if (cow_support) toggle_cow(fd, !tc->no_cow); diff --git a/testcases/kernel/syscalls/getdents/getdents02.c b/testcases/kernel/syscalls/getdents/getdents02.c index 7b023c53f..4cf54aea3 100644 --- a/testcases/kernel/syscalls/getdents/getdents02.c +++ b/testcases/kernel/syscalls/getdents/getdents02.c @@ -158,7 +158,7 @@ static void test_enotdir(void) struct linux_dirent64 dir64; struct linux_dirent dir; - fd = SAFE_OPEN(cleanup, "test", O_CREAT | O_RDWR); + fd = SAFE_OPEN(cleanup, "test", O_CREAT | O_RDWR, 0644); if (longsyscall) getdents64(fd, &dir64, sizeof(dir64)); diff --git a/testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c b/testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c index 50d2c5f9a..e6077e479 100644 --- a/testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c +++ b/testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c @@ -29,7 +29,7 @@ static void run(void) cbs[0] = &cb; sigemptyset(&sigmask); - fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT); + fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT, 0644); io_prep_pwrite(&cb, fd, data, 4096, 0); ret = io_setup(1, &ctx); diff --git a/testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c b/testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c index 7cca7fc08..62a8afba3 100644 --- a/testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c +++ b/testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c @@ -42,7 +42,7 @@ static void setup(void) sigemptyset(&sigmask); - fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT); + fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT, 0644); io_prep_pwrite(&cb, fd, data, 4096, 0); ret = io_setup(1, &ctx); diff --git a/testcases/kernel/syscalls/kcmp/kcmp01.c b/testcases/kernel/syscalls/kcmp/kcmp01.c index 31c2ef3b1..a03a25a2b 100644 --- a/testcases/kernel/syscalls/kcmp/kcmp01.c +++ b/testcases/kernel/syscalls/kcmp/kcmp01.c @@ -43,7 +43,7 @@ static struct test_case { static void setup(void) { - fd1 = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR | O_TRUNC); + fd1 = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR | O_TRUNC, 0666); } static void cleanup(void) diff --git a/testcases/kernel/syscalls/kcmp/kcmp02.c b/testcases/kernel/syscalls/kcmp/kcmp02.c index 1885dc968..993d9a4a4 100644 --- a/testcases/kernel/syscalls/kcmp/kcmp02.c +++ b/testcases/kernel/syscalls/kcmp/kcmp02.c @@ -54,8 +54,8 @@ static void setup(void) pid1 = getpid(); pid_unused = tst_get_unused_pid(); - fd1 = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR | O_TRUNC); - fd2 = SAFE_OPEN(TEST_FILE2, O_CREAT | O_RDWR | O_TRUNC); + fd1 = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR | O_TRUNC, 0644); + fd2 = SAFE_OPEN(TEST_FILE2, O_CREAT | O_RDWR | O_TRUNC, 0644); } static void cleanup(void) diff --git a/testcases/kernel/syscalls/msync/msync04.c b/testcases/kernel/syscalls/msync/msync04.c index dad07b264..7c295d961 100644 --- a/testcases/kernel/syscalls/msync/msync04.c +++ b/testcases/kernel/syscalls/msync/msync04.c @@ -47,7 +47,8 @@ static void test_msync(void) { uint64_t dirty; - test_fd = SAFE_OPEN("msync04/testfile", O_CREAT | O_TRUNC | O_RDWR); + test_fd = SAFE_OPEN("msync04/testfile", O_CREAT | O_TRUNC | O_RDWR, + 0644); SAFE_WRITE(0, test_fd, STRING_TO_WRITE, sizeof(STRING_TO_WRITE) - 1); mmaped_area = SAFE_MMAP(NULL, pagesize, PROT_READ | PROT_WRITE, MAP_SHARED, test_fd, 0); diff --git a/testcases/kernel/syscalls/tee/tee02.c b/testcases/kernel/syscalls/tee/tee02.c index 21296e968..899e93e5f 100644 --- a/testcases/kernel/syscalls/tee/tee02.c +++ b/testcases/kernel/syscalls/tee/tee02.c @@ -44,7 +44,7 @@ static struct tcase { static void setup(void) { - fd = SAFE_OPEN(TEST_FILE, O_RDWR | O_CREAT); + fd = SAFE_OPEN(TEST_FILE, O_RDWR | O_CREAT, 0644); SAFE_PIPE(pipes); SAFE_WRITE(1, pipes[1], STR, sizeof(STR) - 1); }