| Message ID | 20190604074035.4523-1-xzhou@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | lib/tst_test.c: set mount_device amd format_device of all_filesystems is set | expand |
On 2019/06/04 15:40, Murphy Zhou wrote: > preadv203.c does not set mount_device, which makes BROK: > preadv203.c:122: BROK: preadv2() failed: EOPNOTSUPP > > Fixing this by format and mount device if all_filesystems is set in library. > > Signed-off-by: Murphy Zhou<xzhou@redhat.com> > --- > lib/tst_test.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/tst_test.c b/lib/tst_test.c > index 95f389d2e..61dba793e 100644 > --- a/lib/tst_test.c > +++ b/lib/tst_test.c > @@ -808,8 +808,11 @@ static void do_setup(int argc, char *argv[]) > tst_test->format_device = 1; > } > > - if (tst_test->all_filesystems) > + if (tst_test->all_filesystems) { > tst_test->needs_device = 1; > + tst_test->mount_device = 1; > + tst_test->format_device = 1; > + } Hi Murph, 1) tst_test->format_device will be set automatically when we set tst_test->mount_device. 2) It's unreasonable to set tst_test->mount_device for all filesystems forcely because we don't need to mount for all filesystems in some cases(e.g. just test formating). Perhaps, you just add tst_test->mount_device in preadv203.c. :-) Best Regards, Xiao Yang > > setup_ipc(); >
Hi, On Tue, Jun 04, 2019 at 04:09:58PM +0800, Xiao Yang wrote: > On 2019/06/04 15:40, Murphy Zhou wrote: > > preadv203.c does not set mount_device, which makes BROK: > > preadv203.c:122: BROK: preadv2() failed: EOPNOTSUPP > > > > Fixing this by format and mount device if all_filesystems is set in library. > > > > Signed-off-by: Murphy Zhou<xzhou@redhat.com> > > --- > > lib/tst_test.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/lib/tst_test.c b/lib/tst_test.c > > index 95f389d2e..61dba793e 100644 > > --- a/lib/tst_test.c > > +++ b/lib/tst_test.c > > @@ -808,8 +808,11 @@ static void do_setup(int argc, char *argv[]) > > tst_test->format_device = 1; > > } > > > > - if (tst_test->all_filesystems) > > + if (tst_test->all_filesystems) { > > tst_test->needs_device = 1; > > + tst_test->mount_device = 1; > > + tst_test->format_device = 1; > > + } > Hi Murph, > > 1) tst_test->format_device will be set automatically when we set > tst_test->mount_device. Yes. but need to set mount_device in the tcase. > 2) It's unreasonable to set tst_test->mount_device for all filesystems > forcely because we > don't need to mount for all filesystems in some cases(e.g. just test > formating). Good point. > > Perhaps, you just add tst_test->mount_device in preadv203.c. :-) Yes.. That's I forget to say in the commit message. I just recalled this and then I saw your email :) Hi Cyril, what do you think? I'm fine with either way. Thanks, Murphy > > Best Regards, > Xiao Yang > > > > setup_ipc(); > > > > >
diff --git a/lib/tst_test.c b/lib/tst_test.c index 95f389d2e..61dba793e 100644 --- a/lib/tst_test.c +++ b/lib/tst_test.c @@ -808,8 +808,11 @@ static void do_setup(int argc, char *argv[]) tst_test->format_device = 1; } - if (tst_test->all_filesystems) + if (tst_test->all_filesystems) { tst_test->needs_device = 1; + tst_test->mount_device = 1; + tst_test->format_device = 1; + } setup_ipc();
preadv203.c does not set mount_device, which makes BROK: preadv203.c:122: BROK: preadv2() failed: EOPNOTSUPP Fixing this by format and mount device if all_filesystems is set in library. Signed-off-by: Murphy Zhou <xzhou@redhat.com> --- lib/tst_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)