diff mbox series

[v2] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error

Message ID 20180531023740.22811-1-yixin.zhang@intel.com
State Accepted
Delegated to: Petr Vorel
Headers show
Series [v2] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error | expand

Commit Message

Yixin Zhang May 31, 2018, 2:37 a.m. UTC
testcases/network/stress/ssh/ssh-stress01-rmt:57:16: error: Since you
double quoted this, it will not word split, and the loop will only run
once. [SC2066]

Signed-off-by: Yixin Zhang <yixin.zhang@intel.com>
---
 testcases/network/stress/ssh/ssh-stress01-rmt | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Alexey Kodanev June 6, 2018, 10:59 a.m. UTC | #1
On 31.05.2018 05:37, Yixin Zhang wrote:
> testcases/network/stress/ssh/ssh-stress01-rmt:57:16: error: Since you
> double quoted this, it will not word split, and the loop will only run
> once. [SC2066]
> 
> Signed-off-by: Yixin Zhang <yixin.zhang@intel.com>
> ---

Applied, thanks!
diff mbox series

Patch

diff --git a/testcases/network/stress/ssh/ssh-stress01-rmt b/testcases/network/stress/ssh/ssh-stress01-rmt
index 2a84957ca..b2f65793e 100644
--- a/testcases/network/stress/ssh/ssh-stress01-rmt
+++ b/testcases/network/stress/ssh/ssh-stress01-rmt
@@ -53,10 +53,7 @@  done
 # Disconnect all ssh connection
 all_conn=$(ps auxw | grep -Fv grep | \
 	grep "ssh[[:blank:]].*${ssh_config}" | awk '{print $2}')
-
-for ssh_pid in "$all_conn"; do
-	kill $ssh_pid
-done
+kill $all_conn
 
 # Check the connectivity again
 ssh -$ip_ver -F $ssh_config $server_ipaddr \