From patchwork Tue May 15 09:16:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 913496 X-Patchwork-Delegate: chrubis@suse.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lX536ljHz9s0q for ; Tue, 15 May 2018 19:16:55 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 354923E755F for ; Tue, 15 May 2018 11:16:50 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) by picard.linux.it (Postfix) with ESMTP id D96B23E7549 for ; Tue, 15 May 2018 11:16:48 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 53436100049E for ; Tue, 15 May 2018 11:16:46 +0200 (CEST) Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DBF12AE1B; Tue, 15 May 2018 09:16:42 +0000 (UTC) From: Petr Vorel To: ltp@lists.linux.it Date: Tue, 15 May 2018 11:16:26 +0200 Message-Id: <20180515091626.16121-1-pvorel@suse.cz> X-Mailer: git-send-email 2.16.3 X-Virus-Scanned: clamav-milter 0.99.2 at in-4.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-4.smtp.seeweb.it Subject: [LTP] [PATCH 1/1] net/virt_lib.sh: Fix quoting default variable on dash X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Dash (and maybe some other posix shells) needs quoting whole argument, otherwise it's not able to assert: /opt/ltp/testcases/bin/ipvlan01.sh: 384: local: l2,mode: bad variable name /opt/ltp/testcases/bin/vlan01.sh: 360: local: ,protocol: bad variable name The problem was in $opt, change also $start_id to use the same convention. Fixes: dcacbcffe ("network/virt: add test-case 01 to virt_lib.sh") 94aac42a0 ("network/virt: add test-case 02 to virt_lib.sh") Signed-off-by: Petr Vorel --- testcases/network/virt/virt_lib.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/testcases/network/virt/virt_lib.sh b/testcases/network/virt/virt_lib.sh index 72946c5be..095dbf3a3 100644 --- a/testcases/network/virt/virt_lib.sh +++ b/testcases/network/virt/virt_lib.sh @@ -356,8 +356,8 @@ virt_netperf_msg_sizes() # OPTIONS - different options separated by comma. virt_test_01() { - start_id=${start_id:-"1"} - local opts=${1:-""} + start_id="${start_id:-1}" + local opts="${1:-}" local n=0 while true; do @@ -380,8 +380,8 @@ virt_test_01() # OPTIONS - different options separated by comma. virt_test_02() { - start_id=${start_id:-"1"} - local opts=${1:-""} + start_id="${start_id:-1}" + local opts="${1:-}" local n=0 while true; do