From patchwork Fri May 4 12:53:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Palethorpe X-Patchwork-Id: 908694 X-Patchwork-Delegate: chrubis@suse.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.com Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40csQg40YVz9s3D for ; Fri, 4 May 2018 22:54:02 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 710933E6D8E for ; Fri, 4 May 2018 14:53:59 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) by picard.linux.it (Postfix) with ESMTP id 0154E3E6D20 for ; Fri, 4 May 2018 14:53:57 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 99CB92011EB for ; Fri, 4 May 2018 14:53:56 +0200 (CEST) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3995CAB49; Fri, 4 May 2018 12:53:55 +0000 (UTC) From: Richard Palethorpe To: ltp@lists.linux.it Date: Fri, 4 May 2018 14:53:49 +0200 Message-Id: <20180504125349.22734-1-rpalethorpe@suse.com> X-Mailer: git-send-email 2.16.3 X-Virus-Scanned: clamav-milter 0.99.2 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-7.smtp.seeweb.it Cc: Richard Palethorpe Subject: [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" This message creates a lot of noise and uses extra resources on slower machines. It also does not seem very useful. Signed-off-by: Richard Palethorpe --- This may help debug test failures on ARM machines by reducing the amount of noise. include/tst_common.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/tst_common.h b/include/tst_common.h index d3d50eb19..27924766e 100644 --- a/include/tst_common.h +++ b/include/tst_common.h @@ -56,13 +56,10 @@ if (tst_ret_ == ERET) \ break; \ if (tst_delay_ < MAX_DELAY * 1000000) { \ - tst_res(TINFO, \ - #FUNC" returned %i, retrying" \ - " in %ius", tst_ret_, tst_delay_); \ usleep(tst_delay_); \ tst_delay_ *= 2; \ } else { \ - tst_brk(TBROK, #FUNC" failed"); \ + tst_brk(TBROK, #FUNC" timed out"); \ } \ } \ ERET; \