| Message ID | 20180314104059.28051-1-rpalethorpe@suse.com |
|---|---|
| State | Accepted |
| Delegated to: | Alexey Kodanev |
| Headers | show |
| Series | lib: fix length check in safe_sendmsg | expand |
On 03/14/2018 01:40 PM, Richard Palethorpe wrote: > It appears that we only check the len parameter against the return value if > the len parameter is zero. > > Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> > --- > lib/safe_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/safe_net.c b/lib/safe_net.c > index 9ea9d2b42..96216ee69 100644 > --- a/lib/safe_net.c > +++ b/lib/safe_net.c > @@ -200,7 +200,7 @@ ssize_t safe_sendmsg(const char *file, const int lineno, size_t len, > file, lineno, sockfd, msg, flags); > } > > - if (!len && (size_t)rval != len) { > + if (len && (size_t)rval != len) { > tst_brkm(TBROK, NULL, > "%s:%d: sendmsg(%d, %p, %d) ret(%zd) != len(%zu)", > file, lineno, sockfd, msg, flags, rval, len); > Applied. Nice catch, thank you Richard!
diff --git a/lib/safe_net.c b/lib/safe_net.c index 9ea9d2b42..96216ee69 100644 --- a/lib/safe_net.c +++ b/lib/safe_net.c @@ -200,7 +200,7 @@ ssize_t safe_sendmsg(const char *file, const int lineno, size_t len, file, lineno, sockfd, msg, flags); } - if (!len && (size_t)rval != len) { + if (len && (size_t)rval != len) { tst_brkm(TBROK, NULL, "%s:%d: sendmsg(%d, %p, %d) ret(%zd) != len(%zu)", file, lineno, sockfd, msg, flags, rval, len);
It appears that we only check the len parameter against the return value if the len parameter is zero. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- lib/safe_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)