| Message ID | 1694770631-9547-1-git-send-email-xuyang2018.jy@fujitsu.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/4] readlinkat: Remove readlinkat fallback definition | expand |
HI
Ping.
Best Regards
Yang Xu
Looking at man readlinkat, it was added into kernel 2.6.16 and since the
oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions
.txt) we can as well completely drop this fallback definition.
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com><mailto:xuyang2018.jy@fujitsu.com>
---
configure.ac | 1 -
include/lapi/readlinkat.h | 21 ---------------------
2 files changed, 22 deletions(-)
delete mode 100644 include/lapi/readlinkat.h
diff --git a/configure.ac b/configure.ac
index 662c4c058..80943bdea 100644
--- a/configure.ac
+++ b/configure.ac
@@ -133,7 +133,6 @@ AC_CHECK_FUNCS_ONCE([ \
pwritev2 \
quotactl_fd \
rand_r \
- readlinkat \
recvmmsg \
renameat \
renameat2 \
diff --git a/include/lapi/readlinkat.h b/include/lapi/readlinkat.h
deleted file mode 100644
index a680deeec..000000000
--- a/include/lapi/readlinkat.h
+++ /dev/null
@@ -1,21 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz><mailto:chrubis@suse.cz>
- */
-
-#ifndef LAPI_READLINKAT_H__
-#define LAPI_READLINKAT_H__
-
-#include "config.h"
-#include "lapi/syscalls.h"
-#include "lapi/fcntl.h"
-
-#ifndef HAVE_READLINKAT
-static inline int readlinkat(int dirfd, const char *pathname,
- char *buf, size_t bufsiz)
-{
- return tst_syscall(__NR_readlinkat, dirfd, pathname, buf, bufsiz);
-}
-#endif
-
-#endif /* LAPI_READLINKAT_H__ */
Hi Yang, > Looking at man readlinkat, it was added into kernel 2.6.16 and since the > oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions > .txt) we can as well completely drop this fallback definition. Again, as I mentioned in v2 renameat() patch [1], the real reason for this lapi function was IMHO missing glibc wrapper. The correct git commit message should have been glibc wrapper was added in ... Also, without kernel support the function would not work at all, therefore it is irrelevant when readlinkat was added into kernel. That applies to all git commit messages. Due me merged v2 renameat() first, this is not applicable (patch must be modified, I'm sorry). This particular patch would deserve to note that since these 2 commits the lapi is not even used (both released in 20230929 - a proof it can be really deleted): 0959b893a ("syscalls/readlinkat01: Convert to new API") bcafe2971 ("syscalls/readlinkat02: Convert to new API") Kind regards, Petr [1] https://lore.kernel.org/ltp/20231016080349.GA844528@pevik/
Hi Petr, > Hi Yang, > >> Looking at man readlinkat, it was added into kernel 2.6.16 and since the >> oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions >> .txt) we can as well completely drop this fallback definition. > Again, as I mentioned in v2 renameat() patch [1], the real reason for this lapi > function was IMHO missing glibc wrapper. The correct git commit message should > have been glibc wrapper was added in ... > > Also, without kernel support the function would not work at all, therefore it is > irrelevant when readlinkat was added into kernel. That applies to all git commit > messages. Due me merged v2 renameat() first, this is not applicable (patch must > be modified, I'm sorry). > > This particular patch would deserve to note that since these 2 commits the lapi > is not even used (both released in 20230929 - a proof it can be really deleted): > > 0959b893a ("syscalls/readlinkat01: Convert to new API") > bcafe2971 ("syscalls/readlinkat02: Convert to new API") > > Kind regards, > Petr > > [1] https://lore.kernel.org/ltp/20231016080349.GA844528@pevik/ OK.Thanks for the patient review.I'll modify it. Best Regard, Yang Xu
diff --git a/configure.ac b/configure.ac index 662c4c058..80943bdea 100644 --- a/configure.ac +++ b/configure.ac @@ -133,7 +133,6 @@ AC_CHECK_FUNCS_ONCE([ \ pwritev2 \ quotactl_fd \ rand_r \ - readlinkat \ recvmmsg \ renameat \ renameat2 \ diff --git a/include/lapi/readlinkat.h b/include/lapi/readlinkat.h deleted file mode 100644 index a680deeec..000000000 --- a/include/lapi/readlinkat.h +++ /dev/null @@ -1,21 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-or-later -/* - * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz> - */ - -#ifndef LAPI_READLINKAT_H__ -#define LAPI_READLINKAT_H__ - -#include "config.h" -#include "lapi/syscalls.h" -#include "lapi/fcntl.h" - -#ifndef HAVE_READLINKAT -static inline int readlinkat(int dirfd, const char *pathname, - char *buf, size_t bufsiz) -{ - return tst_syscall(__NR_readlinkat, dirfd, pathname, buf, bufsiz); -} -#endif - -#endif /* LAPI_READLINKAT_H__ */
Looking at man readlinkat, it was added into kernel 2.6.16 and since the oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions .txt) we can as well completely drop this fallback definition. Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> --- configure.ac | 1 - include/lapi/readlinkat.h | 21 --------------------- 2 files changed, 22 deletions(-) delete mode 100644 include/lapi/readlinkat.h