| Message ID | 1637972238-105160-1-git-send-email-wenyehai@huawei.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | bugfix for vmsplice/vmsplice02.c | expand |
Hi wen > vmsplice/vmsplice02: Remove duplicate header files fcntl.h. > > Signed-off-by: Yehai Wen<wenyehai@huawei.com> > --- > testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c > index 39c407c..3dc623f 100644 > --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c > +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c > @@ -20,7 +20,6 @@ > #include<sys/stat.h> > #include<fcntl.h> > #include<unistd.h> > -#include<fcntl.h> > #include<sys/uio.h> > #include<limits.h> Actually, lapi/fcntl.h has included fcntl.h, so the latter fcnlt.h also can be removed. It looks ltp other places also exist this duplicate header files fcntl.h because of lapi/fcntl.h. I think we should remove fcntl.h for these cases when them use lapi/fcntl.h. You can use "git grep "fcntl.h" " cmd to search them. Best Regards Yang Xu >
Hi Yang Xu: Thank you very much for your kind suggestions. I had check with command "git grep "fcntl.h", the result shows that there are 1020 lines used "fcntl.h", and modified 34 testcases involved with the following patch: 0001-bugfix-for-testcases-which-with-duplicate-header-fil.patch Subject: [LTP][PATCH v2] bugfix for testcases which with duplicate header files Best Regards Yehai Wen -----邮件原件----- 发件人: xuyang2018.jy@fujitsu.com [mailto:xuyang2018.jy@fujitsu.com] 发送时间: 2021年12月1日 9:07 收件人: wenyehai <wenyehai@huawei.com> 抄送: wenyehai via ltp <ltp@lists.linux.it> 主题: Re: [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c Hi wen > vmsplice/vmsplice02: Remove duplicate header files fcntl.h. > > Signed-off-by: Yehai Wen<wenyehai@huawei.com> > --- > testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c > b/testcases/kernel/syscalls/vmsplice/vmsplice02.c > index 39c407c..3dc623f 100644 > --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c > +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c > @@ -20,7 +20,6 @@ > #include<sys/stat.h> > #include<fcntl.h> > #include<unistd.h> > -#include<fcntl.h> > #include<sys/uio.h> > #include<limits.h> Actually, lapi/fcntl.h has included fcntl.h, so the latter fcnlt.h also can be removed. It looks ltp other places also exist this duplicate header files fcntl.h because of lapi/fcntl.h. I think we should remove fcntl.h for these cases when them use lapi/fcntl.h. You can use "git grep "fcntl.h" " cmd to search them. Best Regards Yang Xu >
diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c index 39c407c..3dc623f 100644 --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c @@ -20,7 +20,6 @@ #include <sys/stat.h> #include <fcntl.h> #include <unistd.h> -#include <fcntl.h> #include <sys/uio.h> #include <limits.h>
vmsplice/vmsplice02: Remove duplicate header files fcntl.h. Signed-off-by: Yehai Wen <wenyehai@huawei.com> --- testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 - 1 file changed, 1 deletion(-)