| Message ID | 1598250984-5141-1-git-send-email-xuyang2018.jy@cn.fujitsu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | travis: Add centos7 build | expand |
Hi Xu, > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. > Add centos7 travis target, it is more friendly for centos7 user and it is more > meaningful than centos6. OK, how about replacing CentOS 6 with CentOS 7? Kind regards, Petr > I have tested this patch on my ltp fork: > https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105 > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > --- > .travis.yml | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/.travis.yml b/.travis.yml > index e8e3189af..281ec9e96 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -47,6 +47,10 @@ matrix: > env: DISTRO=centos:6 TREE=out > compiler: gcc > + - os: linux > + env: DISTRO=centos:7 TREE=out > + compiler: gcc > + > - os: linux > env: DISTRO=debian:testing > compiler: gcc
Hi Petr > Hi Xu, > >> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. >> Add centos7 travis target, it is more friendly for centos7 user and it is more >> meaningful than centos6. > > OK, how about replacing CentOS 6 with CentOS 7? I have no objection about this because my kernel test team only uses centos7/8 to test and doesn't use centos6 for a long time. But I think ltp community should reach a consensus that minimal glibc/kernel/gcc(clang) version , so we can drop the corresponding code in travis or m4. Also, we can raise "Define minimal supported kernel and (g)libc version" topic again. Best Regards Yang Xu > > Kind regards, > Petr > >> I have tested this patch on my ltp fork: >> https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105 > >> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> >> --- >> .travis.yml | 4 ++++ >> 1 file changed, 4 insertions(+) > >> diff --git a/.travis.yml b/.travis.yml >> index e8e3189af..281ec9e96 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -47,6 +47,10 @@ matrix: >> env: DISTRO=centos:6 TREE=out >> compiler: gcc > >> + - os: linux >> + env: DISTRO=centos:7 TREE=out >> + compiler: gcc >> + >> - os: linux >> env: DISTRO=debian:testing >> compiler: gcc > >
Hi Xu, > > > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. > > > Add centos7 travis target, it is more friendly for centos7 user and it is more > > > meaningful than centos6. > > OK, how about replacing CentOS 6 with CentOS 7? > I have no objection about this because my kernel test team only uses > centos7/8 to test and doesn't use centos6 for a long time. OK. I don't have either, although I hesitated to sent this patch. > But I think ltp community should reach a consensus that minimal > glibc/kernel/gcc(clang) version , so we can drop the corresponding code in > travis or m4. > Also, we can raise "Define minimal supported kernel and (g)libc version" > topic again. Well, last time I remember we decide to drop CentOS 6 after the release. But I haven't done it. I also planned to create wiki pagge "Supported kernel and libc", but haven't done it. Feel free to send a patch for any of these two. But I'd prefer to do the replacement (7 instead of 6) instead of adding it, because travis already run for quite long. Kind regards, Petr
Hi Petr > Hi Xu, > >>>> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. >>>> Add centos7 travis target, it is more friendly for centos7 user and it is more >>>> meaningful than centos6. > >>> OK, how about replacing CentOS 6 with CentOS 7? >> I have no objection about this because my kernel test team only uses >> centos7/8 to test and doesn't use centos6 for a long time. > OK. I don't have either, although I hesitated to sent this patch. > >> But I think ltp community should reach a consensus that minimal >> glibc/kernel/gcc(clang) version , so we can drop the corresponding code in >> travis or m4. > >> Also, we can raise "Define minimal supported kernel and (g)libc version" >> topic again. > Well, last time I remember we decide to drop CentOS 6 after the release. But I > haven't done it. I also planned to create wiki pagge "Supported kernel and > libc", but haven't done it. Feel free to send a patch for any of these two. > But I'd prefer to do the replacement (7 instead of 6) instead of adding it, > because travis already run for quite long. OK. I will send a v2 patch to replace centos6 with centos7 in travis. Best Regards Yang Xu > > Kind regards, > Petr > >
diff --git a/.travis.yml b/.travis.yml index e8e3189af..281ec9e96 100644 --- a/.travis.yml +++ b/.travis.yml @@ -47,6 +47,10 @@ matrix: env: DISTRO=centos:6 TREE=out compiler: gcc + - os: linux + env: DISTRO=centos:7 TREE=out + compiler: gcc + - os: linux env: DISTRO=debian:testing compiler: gcc
I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. Add centos7 travis target, it is more friendly for centos7 user and it is more meaningful than centos6. I have tested this patch on my ltp fork: https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105 Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- .travis.yml | 4 ++++ 1 file changed, 4 insertions(+)