From patchwork Thu Jun 6 15:21:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yann Sionneau X-Patchwork-Id: 1111244 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=kalray.eu Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kalray.eu header.i=@kalray.eu header.b="iwMWWvQe"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45KVy86hRTz9s9y for ; Fri, 7 Jun 2019 02:10:53 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 959303EA441 for ; Thu, 6 Jun 2019 18:10:43 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) by picard.linux.it (Postfix) with ESMTP id 7FBC4298797 for ; Thu, 6 Jun 2019 17:21:45 +0200 (CEST) Received: from zimbra2.kalray.eu (zimbra2.kalray.eu [92.103.151.219]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 4C815600B8D for ; Thu, 6 Jun 2019 17:21:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id E040027FFC75 for ; Thu, 6 Jun 2019 17:21:43 +0200 (CEST) Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nG72XU1hnaAO; Thu, 6 Jun 2019 17:21:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id 98FCD27FFC03; Thu, 6 Jun 2019 17:21:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu 98FCD27FFC03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalray.eu; s=32AE1B44-9502-11E5-BA35-3734643DEF29; t=1559834497; bh=Z/lwHLU90ZURxfgEXGxJKK1QYj7QVykJ9ELjJa93ufE=; h=From:To:Date:Message-Id; b=iwMWWvQebbnym8gt8YprwCN52qpBq99YQ7+Ul2qXGGWKEFhQVVv+KV08vBa6lr6st Qjgot5Jiw1ul4fyy0i721FrHPk3PCs41PGBnMaYhqTOQrOXvBeRyU6cMHm4H6od8fL alZUFs9spICCrFVo72VWkAgwye1DMooadLn5WSI8= Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UdffvjQwO1ZI; Thu, 6 Jun 2019 17:21:37 +0200 (CEST) Received: from junon.lin.mbt.kalray.eu (unknown [192.168.37.161]) by zimbra2.kalray.eu (Postfix) with ESMTPSA id 799FF27FA151; Thu, 6 Jun 2019 17:21:37 +0200 (CEST) From: Yann Sionneau To: ltp@lists.linux.it Date: Thu, 6 Jun 2019 17:21:17 +0200 Message-Id: <1559834477-21724-1-git-send-email-ysionneau@kalray.eu> X-Mailer: git-send-email 1.8.3.1 X-Virus-Scanned: clamav-milter 0.99.2 at in-5.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-5.smtp.seeweb.it X-Mailman-Approved-At: Thu, 06 Jun 2019 18:10:41 +0200 Cc: ysionneau@kalray.eu Subject: [LTP] [PATCH] Fix use of results after being unmapped X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" This fixes issue reported there: https://github.com/linux-test-project/ltp/issues/537 --- lib/tst_test.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/tst_test.c b/lib/tst_test.c index 95f389d..73eca58 100644 --- a/lib/tst_test.c +++ b/lib/tst_test.c @@ -138,6 +138,7 @@ static void cleanup_ipc(void) if (results) { msync((void*)results, size, MS_SYNC); munmap((void*)results, size); + results = NULL; } } @@ -921,10 +922,11 @@ static void do_cleanup(void) if (tst_test->save_restore) tst_sys_conf_restore(0); - cleanup_ipc(); - if (tst_test->restore_wallclock) tst_wallclock_restore(); + + cleanup_ipc(); + /* Do not use 'results' after cleanup_ipc(): it has been unmapped. */ } static void run_tests(void)