mbox series

[v4,0/8] syscalls/mknod: Refactor all tests

Message ID 20250425-conversions-mknod-v4-0-222e0d2e7ef1@suse.com
Headers show
Series syscalls/mknod: Refactor all tests | expand

Message

Ricardo B. Marlière April 25, 2025, 6:06 p.m. UTC 
If needed, you can find this series available here:

https://git.marliere.net/ltp/ltp/

`git clone --branch conversions/mknod --single-branch https://git.marliere.net/ltp/ltp/`

Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
Changes in v4:
- Fixed modes bits in all tests
- Removed unnecessary SAFE_STAT call in mknod03 (SAFE_CHMOD is enough)
- Fixed %ld warning in mknod01
- Rebased
- Link to v3: https://lore.kernel.org/r/20250414-conversions-mknod-v3-0-e08e7463bfaa@suse.com

Changes in v3:
- mknod03:
	Fixed test description alignment
	Removed an outdated comment (CVE)
	Made functions static
	Moved setgid() and setreuid() calls to setup()
	Rename TST_DIR and TST_NODE to TEMP_*
- Also refactored remaining mknod tests
- Link to v2: https://lore.kernel.org/r/20250321-conversions-mknod-v2-1-c9c27bde5b07@suse.com

Changes in v2:
- Made use of TST_EXP_EQ_LI
- Moved test tmp directory creation into setup()
- Removed now unneeded orig_uid
- Link to v1: https://lore.kernel.org/r/20250319-conversions-mknod-v1-1-f46e763d7200@suse.com

---
Ricardo B. Marlière (8):
      syscalls/mknod01: Fix checkpatch.pl warnings
      syscalls/mknod02: Use relative path to avoid use of SAFE_CHDIR
      syscalls/mknod03: Convert to new API
      syscalls/mknod04: Convert to new API
      syscalls/mknod05: Convert to new API
      syscalls/mknod06: Convert to new API
      syscalls/mknod07: Convert to new API
      syscalls/mknod08: Convert to new API

 testcases/kernel/syscalls/mknod/mknod01.c |   7 +-
 testcases/kernel/syscalls/mknod/mknod02.c |   4 +-
 testcases/kernel/syscalls/mknod/mknod03.c | 313 ++++-------------------------
 testcases/kernel/syscalls/mknod/mknod04.c | 319 ++++--------------------------
 testcases/kernel/syscalls/mknod/mknod05.c | 285 ++++----------------------
 testcases/kernel/syscalls/mknod/mknod06.c | 301 ++++------------------------
 testcases/kernel/syscalls/mknod/mknod07.c | 209 ++++++--------------
 testcases/kernel/syscalls/mknod/mknod08.c | 312 ++++-------------------------
 8 files changed, 261 insertions(+), 1489 deletions(-)
---
base-commit: 037cb53e353abb571e52b52cbaa6b569ac28c50c
change-id: 20250319-conversions-mknod-cd8cb407d24d

Best regards,

Comments

Andrea Cervesato June 4, 2025, 2:36 p.m. UTC | #1 
All patches look good to me. we should be able to merge them.

@Petr WDYT?
Ricardo B. Marlière June 4, 2025, 2:37 p.m. UTC | #2 
On Wed Jun 4, 2025 at 11:36 AM -03, Andrea Cervesato wrote:
> All patches look good to me. we should be able to merge them.
>
> @Petr WDYT?

Cool, thanks for reviewing! :)