mbox series

[0/2] Add TST_NET_IPV{4,6}_ONLY and use on broken_ip

Message ID 20210714140716.1568-1-pvorel@suse.cz
Headers show
Series Add TST_NET_IPV{4,6}_ONLY and use on broken_ip | expand

Message

Petr Vorel July 14, 2021, 2:07 p.m. UTC
Hi Alexey,

https://github.com/linux-test-project/ltp/issues/843

does it make sense to run it on IPv4 and broken_ip-totlen on IPv6?
Both don't break but not in runtest file.

Kind regards,
Petr

Petr Vorel (2):
  tst_net.sh: Add variable for supported protocol
  broken_ip: TCONF when test run on unsupported protocol

 testcases/lib/tst_net.sh                              | 8 ++++++++
 testcases/lib/tst_test.sh                             | 2 +-
 testcases/network/stress/broken_ip/broken_ip-checksum | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-fragment | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-ihl      | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-nexthdr  | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-protcol  | 3 ++-
 7 files changed, 19 insertions(+), 6 deletions(-)

Comments

Alexey Kodanev July 15, 2021, 9:38 a.m. UTC | #1
On 14.07.2021 17:07, Petr Vorel wrote:
> Hi Alexey,
> 
> https://github.com/linux-test-project/ltp/issues/843
> 
> does it make sense to run it on IPv4 and broken_ip-totlen on IPv6?
> Both don't break but not in runtest file.

Hi Petr,

Yes it should work with the -L option, but these tests are the same
(differs the descriptions for IPv4/IPv6):

diff -u broken_ip-plen broken_ip-totlen
--- broken_ip-plen	2020-10-08 22:23:52.000000000 +0300
+++ broken_ip-totlen	2020-10-08 22:23:52.000000000 +0300
@@ -10,7 +10,7 @@

 do_test()
 {
-	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong payload len for $NS_DURATION sec"
+	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong total len field for $NS_DURATION sec"
 	tst_icmp -t $NS_DURATION -s "0 100 500 1000 $NS_ICMP_SENDER_DATA_MAXSIZE" -L
 	tst_ping
 }

So broken_ip-totlen should be just removed.

> 
> Kind regards,
> Petr
> 
> Petr Vorel (2):
>   tst_net.sh: Add variable for supported protocol
>   broken_ip: TCONF when test run on unsupported protocol
> 
>  testcases/lib/tst_net.sh                              | 8 ++++++++
>  testcases/lib/tst_test.sh                             | 2 +-
>  testcases/network/stress/broken_ip/broken_ip-checksum | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-fragment | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-ihl      | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-nexthdr  | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-protcol  | 3 ++-
>  7 files changed, 19 insertions(+), 6 deletions(-)
>
Petr Vorel July 15, 2021, 11:58 a.m. UTC | #2
> On 14.07.2021 17:07, Petr Vorel wrote:
> > Hi Alexey,

> > https://github.com/linux-test-project/ltp/issues/843

> > does it make sense to run it on IPv4 and broken_ip-totlen on IPv6?
> > Both don't break but not in runtest file.

> Hi Petr,

> Yes it should work with the -L option, but these tests are the same
> (differs the descriptions for IPv4/IPv6):

> diff -u broken_ip-plen broken_ip-totlen
> --- broken_ip-plen	2020-10-08 22:23:52.000000000 +0300
> +++ broken_ip-totlen	2020-10-08 22:23:52.000000000 +0300
> @@ -10,7 +10,7 @@

>  do_test()
>  {
> -	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong payload len for $NS_DURATION sec"
> +	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong total len field for $NS_DURATION sec"
>  	tst_icmp -t $NS_DURATION -s "0 100 500 1000 $NS_ICMP_SENDER_DATA_MAXSIZE" -L
>  	tst_ping
>  }

Good catch, thanks!

> So broken_ip-totlen should be just removed.
I merged commit which implements this.

Kind regards,
Petr