mbox series

[0/3] lib/tst_net.sh: calc median instead of mean in tst_netload()

Message ID 20210202133454.59224-1-alexey.kodanev@oracle.com
Headers show
Series lib/tst_net.sh: calc median instead of mean in tst_netload() | expand

Message

Alexey Kodanev Feb. 2, 2021, 1:34 p.m. UTC 
This series of patches is intended to improve the reliability
of results in network tests that using tst_netload().

After TST_NETLOAD_RUN_COUNT was added, we get several results (5 by
default). The first patch allows all of them to be displayed along
with the final result. It helps to debug test performance failures.

Further patches replace the mean calculation of such data set with
the median one. It allows to exclude extreme points from the final
result.

Alexey Kodanev (3):
  lib/tst_net.sh: print all netstress results in tst_netload()
  lib: add tst_get_median helper binary for use in script tests
  lib/tst_net.sh: calc median instead of mean in tst_netload()

 testcases/lib/.gitignore       |  1 +
 testcases/lib/Makefile         |  3 ++-
 testcases/lib/tst_get_median.c | 37 ++++++++++++++++++++++++++++++++++
 testcases/lib/tst_net.sh       | 10 ++++-----
 4 files changed, 45 insertions(+), 6 deletions(-)
 create mode 100644 testcases/lib/tst_get_median.c

Comments

Petr Vorel Feb. 5, 2021, 10:21 a.m. UTC | #1 
Hi Alexey,

> This series of patches is intended to improve the reliability
> of results in network tests that using tst_netload().

> After TST_NETLOAD_RUN_COUNT was added, we get several results (5 by
> default). The first patch allows all of them to be displayed along
> with the final result. It helps to debug test performance failures.

> Further patches replace the mean calculation of such data set with
> the median one. It allows to exclude extreme points from the final
> result.

Thanks for improving stability of these tests!
I've also noticed often failures in net.features and some of ipsec tests,
this should help.

FYI as TODO I'd like some of net.features have also as functional tests
(ignoring the performance).

Kind regards,
Petr
Alexey Kodanev Feb. 8, 2021, 3:24 p.m. UTC | #2 
On 05.02.2021 13:21, Petr Vorel wrote:
> Hi Alexey,
> 
>> This series of patches is intended to improve the reliability
>> of results in network tests that using tst_netload().
> 
>> After TST_NETLOAD_RUN_COUNT was added, we get several results (5 by
>> default). The first patch allows all of them to be displayed along
>> with the final result. It helps to debug test performance failures.
> 
>> Further patches replace the mean calculation of such data set with
>> the median one. It allows to exclude extreme points from the final
>> result.
> 
> Thanks for improving stability of these tests!
> I've also noticed often failures in net.features and some of ipsec tests,
> this should help.
>
> FYI as TODO I'd like some of net.features have also as functional tests
> (ignoring the performance).
> 

Merged, thanks for review Petr!