mbox series

[v2,00/11] Test metadata extraction

Message ID 20201103191327.11081-1-pvorel@suse.cz
Headers show
Series Test metadata extraction | expand

Message

Petr Vorel Nov. 3, 2020, 7:13 p.m. UTC 
Hi,

address some of the notes added by Li.

changes v1->v2:

3rd commit
https://patchwork.ozlabs.org/project/ltp/patch/20201005133054.23587-4-chrubis@suse.cz/
* add buf[i++] = c; to fix parsing ""
* check fname is valid before opening it
* fix some of checkpatch.pl problems

9th commit
* add perl-libwww-perl for fedora/centos

11 th commit
* add *.css *.js to CLEAN_TARGETS

TODO
* I didn't filter "options". But agree they should be handled better than now.
* some checkpatch.pl warnings left, do we want to bother?
docparse/docparse.c:53: WARNING: Missing a blank line after declarations
docparse/docparse.c:206: ERROR: do not use assignment in if condition
docparse/docparse.c:211: WARNING: Missing a blank line after declarations
docparse/docparse.c:246: ERROR: do not use assignment in if condition
docparse/docparse.c:288: WARNING: Missing a blank line after declarations
docparse/docparse.c:297: WARNING: static const char * array should probably be static const char * const
docparse/docparse.c:352: WARNING: static const char * array should probably be static const char * const
total: 2 errors, 5 warnings, 423 lines checked

* I didn't change docparse/README.md (4th commit, Jan had some notes,
could you phrase what should be there?)

Anything else to change?

Tested: https://travis-ci.org/github/pevik/ltp/builds/741217630

Kind regards,
Petr

Cyril Hrubis (4):
  docparse: Add test documentation parser
  docparse: Add README
  syscalls: Add a few documentation comments
  syscalls: Move needs_drivers inside of the tst_test struct

Petr Vorel (7):
  make: Support compiling native build tools
  travis: Add git
  make: Allow {INSTALL, MAKE}_TARGETS be a directory
  make: Allow CLEAN_TARGETS to remove directories
  travis: Install docparse dependencies
  docparse: Add configure options
  docparse: Generate html and pdf using asciidoc{, tor}

 Makefile                                      |   4 +
 configure.ac                                  |  32 +-
 docparse/.gitignore                           |   7 +
 docparse/Makefile                             |  77 ++++
 docparse/README.md                            | 248 ++++++++++
 docparse/data_storage.h                       | 299 ++++++++++++
 docparse/docparse.c                           | 423 +++++++++++++++++
 docparse/parse.sh                             |  41 ++
 docparse/testinfo.pl                          | 424 ++++++++++++++++++
 include/mk/config.mk.in                       |  21 +
 include/mk/env_post.mk                        |   3 +-
 include/mk/features.mk.in                     |   5 +
 include/mk/functions.mk                       |   3 +-
 include/mk/generic_leaf_target.inc            |  16 +-
 include/mk/rules.mk                           |   8 +
 m4/ax_compare_version.m4                      | 177 ++++++++
 m4/ax_prog_perl_modules.m4                    |  77 ++++
 m4/ltp-docparse.m4                            | 112 +++++
 testcases/kernel/syscalls/abort/abort01.c     |  16 +-
 testcases/kernel/syscalls/accept/accept01.c   |   8 +-
 testcases/kernel/syscalls/accept/accept02.c   |   7 +-
 testcases/kernel/syscalls/acct/acct01.c       |   5 +
 testcases/kernel/syscalls/acct/acct02.c       |   6 +-
 .../kernel/syscalls/fsetxattr/fsetxattr02.c   |  10 +-
 testcases/kernel/syscalls/ioctl/ioctl08.c     |   9 +-
 travis/alpine.sh                              |   4 +
 travis/debian.minimal.sh                      |   8 +-
 travis/debian.sh                              |  10 +-
 travis/fedora.sh                              |  13 +-
 travis/tumbleweed.sh                          |   9 +-
 30 files changed, 2043 insertions(+), 39 deletions(-)
 create mode 100644 docparse/.gitignore
 create mode 100644 docparse/Makefile
 create mode 100644 docparse/README.md
 create mode 100644 docparse/data_storage.h
 create mode 100644 docparse/docparse.c
 create mode 100755 docparse/parse.sh
 create mode 100755 docparse/testinfo.pl
 create mode 100644 m4/ax_compare_version.m4
 create mode 100644 m4/ax_prog_perl_modules.m4
 create mode 100644 m4/ltp-docparse.m4

Comments

Petr Vorel Nov. 12, 2020, 1:11 p.m. UTC | #1 
Hi,

> address some of the notes added by Li.

> changes v1->v2:

> 3rd commit
> https://patchwork.ozlabs.org/project/ltp/patch/20201005133054.23587-4-chrubis@suse.cz/
> * add buf[i++] = c; to fix parsing ""
> * check fname is valid before opening it
> * fix some of checkpatch.pl problems

> 9th commit
> * add perl-libwww-perl for fedora/centos

> 11 th commit
> * add *.css *.js to CLEAN_TARGETS

> TODO
> * I didn't filter "options". But agree they should be handled better than now.
> * some checkpatch.pl warnings left, do we want to bother?
> docparse/docparse.c:53: WARNING: Missing a blank line after declarations
> docparse/docparse.c:206: ERROR: do not use assignment in if condition
> docparse/docparse.c:211: WARNING: Missing a blank line after declarations
> docparse/docparse.c:246: ERROR: do not use assignment in if condition
> docparse/docparse.c:288: WARNING: Missing a blank line after declarations
> docparse/docparse.c:297: WARNING: static const char * array should probably be static const char * const
> docparse/docparse.c:352: WARNING: static const char * array should probably be static const char * const
> total: 2 errors, 5 warnings, 423 lines checked

> * I didn't change docparse/README.md (4th commit, Jan had some notes,
> could you phrase what should be there?)

> Anything else to change?

Anybody against pushing whole patchset [1] with fix below for third commit
("docparse: Add test documentation parser").


Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/list/?series=211956&state=*

Fix for third commit:

diff --git docparse/docparse.c docparse/docparse.c
index 63d131c87..be6125353 100644
--- docparse/docparse.c
+++ docparse/docparse.c
@@ -138,10 +138,8 @@ const char *next_token(FILE *f, struct data_node *doc)
 
 		if (in_str) {
 			if (c == '"') {
-				if (i == 0 || buf[i-1] != '\\') {
-					buf[i++] = c;
+				if (i == 0 || buf[i-1] != '\\')
 					goto exit;
-				}
 			}
 
 			buf[i++] = c;
@@ -189,7 +187,7 @@ const char *next_token(FILE *f, struct data_node *doc)
 	}
 
 exit:
-	if (i == 0)
+	if (i == 0 && !in_str)
 		return NULL;
 
 	buf[i] = 0;
Petr Vorel Nov. 13, 2020, 5:06 p.m. UTC | #2 
Hi Li,

...
> Anybody against pushing whole patchset [1] with fix below for third commit
> ("docparse: Add test documentation parser").

Going to merge whole patchset with diff below
(https://github.com/pevik/ltp/commits/test-metadata-extraction.v2.fixes).

Can I add you Reviewed-by: tag to whole patchset or a subset?

Kind regards,
Petr


> Kind regards,
> Petr

> [1] https://patchwork.ozlabs.org/project/ltp/list/?series=211956&state=*

> Fix for third commit:

> diff --git docparse/docparse.c docparse/docparse.c
> index 63d131c87..be6125353 100644
> --- docparse/docparse.c
> +++ docparse/docparse.c
> @@ -138,10 +138,8 @@ const char *next_token(FILE *f, struct data_node *doc)

>  		if (in_str) {
>  			if (c == '"') {
> -				if (i == 0 || buf[i-1] != '\\') {
> -					buf[i++] = c;
> +				if (i == 0 || buf[i-1] != '\\')
>  					goto exit;
> -				}
>  			}

>  			buf[i++] = c;
> @@ -189,7 +187,7 @@ const char *next_token(FILE *f, struct data_node *doc)
>  	}

>  exit:
> -	if (i == 0)
> +	if (i == 0 && !in_str)
>  		return NULL;

>  	buf[i] = 0;
Li Wang Nov. 16, 2020, 6:21 a.m. UTC | #3 
Hi Petr,

On Sat, Nov 14, 2020 at 1:07 AM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> ...
> > Anybody against pushing whole patchset [1] with fix below for third
> commit
> > ("docparse: Add test documentation parser").
>
> Going to merge whole patchset with diff below
> (https://github.com/pevik/ltp/commits/test-metadata-extraction.v2.fixes).
>
> Can I add you Reviewed-by: tag to whole patchset or a subset?
>

For the whole patchset:
Reviewed-by: Li Wang <liwang@redhat.com>
Petr Vorel Nov. 16, 2020, 6:30 a.m. UTC | #4 
Hi Li,

> Hi Petr,

> On Sat, Nov 14, 2020 at 1:07 AM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Li,

> > ...
> > > Anybody against pushing whole patchset [1] with fix below for third
> > commit
> > > ("docparse: Add test documentation parser").

> > Going to merge whole patchset with diff below
> > (https://github.com/pevik/ltp/commits/test-metadata-extraction.v2.fixes).

> > Can I add you Reviewed-by: tag to whole patchset or a subset?


> For the whole patchset:
> Reviewed-by: Li Wang <liwang@redhat.com>
Thanks a lot, merged!

Kind regards,
Petr