diff mbox

ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies

Message ID alpine.DEB.2.11.1310292123190.31521@trent.utfs.org (mailing list archive)
State Accepted, archived
Commit de00b30d054857990dc573648e4767ec512009c7
Headers show

Commit Message

Christian Kujau Oct. 30, 2013, 4:25 a.m. UTC
On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
> You probably want to do that to the ADB_PMU_LED_IDE entry not the
> ADB_PMU_LED one which doesn't have a dependency and isn't the one
> selecting LEDS_TRIGGER_IDE_DISK :-)

Right you are, sorry for the mixup. Let me try again:


  Signed-off-by: Christian Kujau <lists@nerdbynature.de>


C.

Comments

Benjamin Herrenschmidt Oct. 31, 2013, 1:37 a.m. UTC | #1
On Tue, 2013-10-29 at 21:25 -0700, Christian Kujau wrote:
> On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
> > You probably want to do that to the ADB_PMU_LED_IDE entry not the
> > ADB_PMU_LED one which doesn't have a dependency and isn't the one
> > selecting LEDS_TRIGGER_IDE_DISK :-)
> 
> Right you are, sorry for the mixup. Let me try again:

And this time without a changeset comment ? :-)

I've copied it from the previous version but next time, re-send the
complete commit.

Cheers,
Ben.

> 
>   Signed-off-by: Christian Kujau <lists@nerdbynature.de>
> 
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 696238b..d26a312 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -103,6 +103,7 @@ config ADB_PMU_LED_IDE
>         bool "Use front LED as IDE LED by default"
>         depends on ADB_PMU_LED
>         depends on LEDS_CLASS
> +       depends on IDE_GD_ATA
>         select LEDS_TRIGGERS
>         select LEDS_TRIGGER_IDE_DISK
>         help
> 
> C.
> -- 
> BOFH excuse #378:
> 
> Operators killed by year 2000 bug bite.
diff mbox

Patch

diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 696238b..d26a312 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -103,6 +103,7 @@  config ADB_PMU_LED_IDE
 	bool "Use front LED as IDE LED by default"
 	depends on ADB_PMU_LED
 	depends on LEDS_CLASS
+	depends on IDE_GD_ATA
 	select LEDS_TRIGGERS
 	select LEDS_TRIGGER_IDE_DISK
 	help