From patchwork Mon Oct 28 11:26:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Kujau X-Patchwork-Id: 286491 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id C6BE62C03E7 for ; Mon, 28 Oct 2013 22:27:15 +1100 (EST) Received: from trent.utfs.org (trent.utfs.org [94.185.90.103]) by ozlabs.org (Postfix) with ESMTP id CB7712C00A0 for ; Mon, 28 Oct 2013 22:26:51 +1100 (EST) Received: by trent.utfs.org (Postfix, from userid 8) id AA98B3DB34; Mon, 28 Oct 2013 12:26:45 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on trent.utfs.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.2 Received: from trent.utfs.org (localhost [127.0.0.1]) by trent.utfs.org (Postfix) with ESMTP id BAFC13DB76; Mon, 28 Oct 2013 12:26:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by trent.utfs.org (Postfix) with ESMTP id 9B19C3DB34; Mon, 28 Oct 2013 12:26:44 +0100 (CET) Date: Mon, 28 Oct 2013 04:26:44 -0700 (PDT) From: Christian Kujau To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 X-AV-Checked: ClamAV using ClamSMTP (127.0.0.1) Cc: Geert Uytterhoeven X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16rc2 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, for quite some time the following is printed (twice) after doing "make oldconfig": [...] scripts/kconfig/conf --oldconfig Kconfig warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS) warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS) I never got around to look into this. But I remember that (when I still had CONFIG_IDE selected, because CONFIG_PATA_MACIO was not working for my PowerBook G5), I always had ADB_PMU_LED_IDE selected, so this option was carried over to my current config. When doing "make menuconfig" with this generated config I could see that all 3 necessary options are selected: Support for PMU based PowerMacs CONFIG_ADB_PMU Support for the Power/iBook front LED CONFIG_ADB_PMU_LED Use front LED as IDE LED by default CONFIG_ADB_PMU_LED_IDE And CONFIG_ADB_PMU_LED_IDE selects CONFIG_LEDS_TRIGGER_IDE_DISK, which in turn depends on CONFIG_IDE_GD_ATA - but in "make menuconfig" I could still *unselect* CONFIG_IDE (since I'm using CONFIG_PATA_MACIO) and the 3 options above were still available. I guess "make oldconfig" noticed that and hence printed the warning above. The following patch causes ADB_PMU_LED to depend on IDE_GD_ATA, so that the options above are only available when IDE_GD_ATA is actually selected and thus eliminates the warning. Signed-off-by: Christian Kujau Being a kbuild n00b, I don't know if this is the correct approach though. After looking through the archives I found that this has been reported by Geert back in 2012 already: https://lkml.org/lkml/2012/3/13/556 Thanks, Christian. diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig index 696238b..f30ac9d 100644 --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -90,6 +90,7 @@ config ADB_PMU config ADB_PMU_LED bool "Support for the Power/iBook front LED" depends on ADB_PMU + depends on IDE_GD_ATA select NEW_LEDS select LEDS_CLASS help