| Message ID | 6f899750554d6ac257eed2a7e0f8a641ca8df97a.1621577151.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | powerpc: Stack tracer fixes | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (258eb1f3aaa9face35e613c229c1337263491ea0) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c index 1deb1bf331ddbd..1e1be297c5d6c7 100644 --- a/arch/powerpc/kernel/stacktrace.c +++ b/arch/powerpc/kernel/stacktrace.c @@ -160,6 +160,10 @@ int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, if (!consume_entry(cookie, ip)) return -EINVAL; + + ip = ftrace_get_traced_func_if_no_stackframe(ip, stack); + if (ip && !consume_entry(cookie, ip)) + return -EINVAL; } return 0; }
With -mprofile-kernel and ppc32, the function tracer is invoked before a function sets up its own stackframe. This results in the traced function not appearing in stack traces. Fix this by checking for ftrace entry and including the traced function in the stack trace. Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> --- While I don't think we expect to see ftrace show up in the trace for a non-running task, I think it is good to cover this scenario. I also think it is ok to consider such traces to be reliable. But, I'm not sure of the implications w.r.t livepatching. - Naveen arch/powerpc/kernel/stacktrace.c | 4 ++++ 1 file changed, 4 insertions(+)