| Message ID | 20250422131040.374427-7-maddy@linux.ibm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Fixes for shellcheck/sparse warnings | expand |
Hi Madhavan, On Tue, 22 Apr 2025 18:40:40 +0530 Madhavan Srinivasan <maddy@linux.ibm.com> wrote: > > -if [ -f $4/$image_name-$1 ]; then > - mv $4/$image_name-$1 $4/$image_name-$1.old > +if [ -f "$4"/"$image_name"-"$1" ]; then > + mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old "$4/$image_name-$1" is just as correct (and similar elsewhere). > fi > > -if [ -f $4/System.map-$1 ]; then > - mv $4/System.map-$1 $4/System-$1.old > +if [ -f "$4"/System.map-"$1" ]; then > + mv "$4"/System.map-"$1" "$4"/System-"$1".old > fi > > -cat $2 > $4/$image_name-$1 > -cp $3 $4/System.map-$1 > +cat "$2" > "$4"/"$image_name"-"$1" > +cp "$3" "$4"/System.map-"$1"
diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh index 101fcb397a0f..c3df6c27ce75 100755 --- a/arch/powerpc/boot/install.sh +++ b/arch/powerpc/boot/install.sh @@ -19,19 +19,19 @@ set -e # this should work for both the pSeries zImage and the iSeries vmlinux.sm -image_name=`basename $2` +image_name=$(basename "$2") echo "Warning: '${INSTALLKERNEL}' command not available... Copying" \ "directly to $4/$image_name-$1" >&2 -if [ -f $4/$image_name-$1 ]; then - mv $4/$image_name-$1 $4/$image_name-$1.old +if [ -f "$4"/"$image_name"-"$1" ]; then + mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old fi -if [ -f $4/System.map-$1 ]; then - mv $4/System.map-$1 $4/System-$1.old +if [ -f "$4"/System.map-"$1" ]; then + mv "$4"/System.map-"$1" "$4"/System-"$1".old fi -cat $2 > $4/$image_name-$1 -cp $3 $4/System.map-$1 +cat "$2" > "$4"/"$image_name"-"$1" +cp "$3" "$4"/System.map-"$1"
Fix shellcheck warning such as "Double quote to prevent globbing and word splitting." and Use $(...) notation instead of legacy backticks `...`. Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> --- arch/powerpc/boot/install.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)