| Message ID | 20230104025754.3019235-1-chancel.liu@nxp.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | ASoC: fsl_micfil: Correct the number of steps on SX controls | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_kernel_qemu | fail | kernel (mpc885_ads_defconfig, korg-5.5.0) failed at step build. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
On Wed, Jan 4, 2023 at 10:58 AM Chancel Liu <chancel.liu@nxp.com> wrote: > The parameter "max" of SOC_SINGLE_SX_TLV() means the number of steps > rather than maximum value. This patch corrects the minimum value to -8 > and the number of steps to 15. > > Signed-off-by: Chancel Liu <chancel.liu@nxp.com> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards Wang Shengjiu > --- > sound/soc/fsl/fsl_micfil.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index d7e6fc996166..d4d3bc7ca87c 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -325,21 +325,21 @@ static int hwvad_detected(struct snd_kcontrol > *kcontrol, > > static const struct snd_kcontrol_new fsl_micfil_snd_controls[] = { > SOC_SINGLE_SX_TLV("CH0 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(0), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(0), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH1 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(1), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(1), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH2 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(2), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(2), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH3 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(3), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(3), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH4 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(4), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(4), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH5 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(5), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(5), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH6 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(6), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(6), 0x8, 0xF, gain_tlv), > SOC_SINGLE_SX_TLV("CH7 Volume", REG_MICFIL_OUT_CTRL, > - MICFIL_OUTGAIN_CHX_SHIFT(7), 0xF, 0x7, gain_tlv), > + MICFIL_OUTGAIN_CHX_SHIFT(7), 0x8, 0xF, gain_tlv), > SOC_ENUM_EXT("MICFIL Quality Select", > fsl_micfil_quality_enum, > micfil_quality_get, micfil_quality_set), > -- > 2.25.1 > >
On Wed, 04 Jan 2023 10:57:54 +0800, Chancel Liu wrote: > The parameter "max" of SOC_SINGLE_SX_TLV() means the number of steps > rather than maximum value. This patch corrects the minimum value to -8 > and the number of steps to 15. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_micfil: Correct the number of steps on SX controls commit: cdfa92eb90f5770b26a79824ef213ebdbbd988b1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index d7e6fc996166..d4d3bc7ca87c 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -325,21 +325,21 @@ static int hwvad_detected(struct snd_kcontrol *kcontrol, static const struct snd_kcontrol_new fsl_micfil_snd_controls[] = { SOC_SINGLE_SX_TLV("CH0 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(0), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(0), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH1 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(1), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(1), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH2 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(2), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(2), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH3 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(3), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(3), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH4 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(4), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(4), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH5 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(5), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(5), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH6 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(6), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(6), 0x8, 0xF, gain_tlv), SOC_SINGLE_SX_TLV("CH7 Volume", REG_MICFIL_OUT_CTRL, - MICFIL_OUTGAIN_CHX_SHIFT(7), 0xF, 0x7, gain_tlv), + MICFIL_OUTGAIN_CHX_SHIFT(7), 0x8, 0xF, gain_tlv), SOC_ENUM_EXT("MICFIL Quality Select", fsl_micfil_quality_enum, micfil_quality_get, micfil_quality_set),
The parameter "max" of SOC_SINGLE_SX_TLV() means the number of steps rather than maximum value. This patch corrects the minimum value to -8 and the number of steps to 15. Signed-off-by: Chancel Liu <chancel.liu@nxp.com> --- sound/soc/fsl/fsl_micfil.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)