| Message ID | 20221122072225.423432-1-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dea681c91d3cd5326f87d0a3c93079573e22ce9a |
| Headers | show |
| Series | powerpc/ps3: mark ps3_system_bus_type static | expand |
Hi Christoph, On 11/21/22 23:22, Christoph Hellwig wrote: > ps3_system_bus_type is only used inside of system-bus.c, so remove > the external declaration and the very outdated comment next to it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > arch/powerpc/include/asm/ps3.h | 4 ---- > arch/powerpc/platforms/ps3/system-bus.c | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) I tested this applied to v6.1-rc6 and it seems to be OK. Thanks for submitting. Acked-by: Geoff Levand <geoff@infradead.org>
On Tue, 22 Nov 2022 08:22:25 +0100, Christoph Hellwig wrote: > ps3_system_bus_type is only used inside of system-bus.c, so remove > the external declaration and the very outdated comment next to it. > > Applied to powerpc/next. [1/1] powerpc/ps3: mark ps3_system_bus_type static https://git.kernel.org/powerpc/c/dea681c91d3cd5326f87d0a3c93079573e22ce9a cheers
diff --git a/arch/powerpc/include/asm/ps3.h b/arch/powerpc/include/asm/ps3.h index 8a0d8fb3532863..d503dbd7856cb8 100644 --- a/arch/powerpc/include/asm/ps3.h +++ b/arch/powerpc/include/asm/ps3.h @@ -425,10 +425,6 @@ static inline void *ps3_system_bus_get_drvdata( return dev_get_drvdata(&dev->core); } -/* These two need global scope for get_arch_dma_ops(). */ - -extern struct bus_type ps3_system_bus_type; - /* system manager */ struct ps3_sys_manager_ops { diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c index 2502e9b17df4ab..38a7e02295c8f2 100644 --- a/arch/powerpc/platforms/ps3/system-bus.c +++ b/arch/powerpc/platforms/ps3/system-bus.c @@ -466,7 +466,7 @@ static struct attribute *ps3_system_bus_dev_attrs[] = { }; ATTRIBUTE_GROUPS(ps3_system_bus_dev); -struct bus_type ps3_system_bus_type = { +static struct bus_type ps3_system_bus_type = { .name = "ps3_system_bus", .match = ps3_system_bus_match, .uevent = ps3_system_bus_uevent,
ps3_system_bus_type is only used inside of system-bus.c, so remove the external declaration and the very outdated comment next to it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/powerpc/include/asm/ps3.h | 4 ---- arch/powerpc/platforms/ps3/system-bus.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-)