| Message ID | 20220813083353.8959-1-pieterjan.camerlynck@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [v2] ASoC: fsl_sai: fix incorrect mclk number in error message | expand |
On Sat, Aug 13, 2022 at 4:34 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote: > In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") > the loop was changed to start iterating from 1 instead of 0. The error > message however was not updated, reporting the wrong clock to the user. > > Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards Wang shengjiu > --- > V2: rebase against latest version > --- > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 7523bb944b21..d430eece1d6b 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device > *pdev) > sai->mclk_clk[i] = devm_clk_get(dev, tmp); > if (IS_ERR(sai->mclk_clk[i])) { > dev_err(dev, "failed to get mclk%d clock: %ld\n", > - i + 1, PTR_ERR(sai->mclk_clk[i])); > + i, PTR_ERR(sai->mclk_clk[i])); > sai->mclk_clk[i] = NULL; > } > } > -- > 2.25.1 > >
On Sat, 13 Aug 2022 10:33:52 +0200, Pieterjan Camerlynck wrote: > In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") > the loop was changed to start iterating from 1 instead of 0. The error > message however was not updated, reporting the wrong clock to the user. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: fix incorrect mclk number in error message commit: dcdfa3471f9c28ee716c687d85701353e2e86fde All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 7523bb944b21..d430eece1d6b 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device *pdev) sai->mclk_clk[i] = devm_clk_get(dev, tmp); if (IS_ERR(sai->mclk_clk[i])) { dev_err(dev, "failed to get mclk%d clock: %ld\n", - i + 1, PTR_ERR(sai->mclk_clk[i])); + i, PTR_ERR(sai->mclk_clk[i])); sai->mclk_clk[i] = NULL; } }
In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user. Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com> --- V2: rebase against latest version --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)