| Message ID | 20220716165028.17693-1-dengshaomin@cdjrlc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | kvm:remove the unexpected word "that" in comments | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 10 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 10 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
Le 16/07/2022 à 18:50, shaom Deng a écrit : > [Vous ne recevez pas souvent de courriers de dengshaomin@cdjrlc.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > delete the repeated word "that" in comments > > Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com> > --- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c > index 514fd45c1994..73c6db20cd8a 100644 > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c > @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm, > * is valid, it is written to the HPT as if an H_ENTER with the > * exact flag set was done. When the invalid count is non-zero > * in the header written to the stream, the kernel will make > - * sure that that many HPTEs are invalid, and invalidate them > + * sure that many HPTEs are invalid, and invalidate them You are changing the meaning here. The sentence is: ... make sure that: that many HPTEs are invalid. You changed the meaning to: ... make sure that: many HPTEs are invalid. It doesn't mean the same. > * if not. > */ > > -- > 2.34.1 >
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 16/07/2022 à 18:50, shaom Deng a écrit : >> [Vous ne recevez pas souvent de courriers de dengshaomin@cdjrlc.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> delete the repeated word "that" in comments >> >> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com> >> --- >> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c >> index 514fd45c1994..73c6db20cd8a 100644 >> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c >> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c >> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm, >> * is valid, it is written to the HPT as if an H_ENTER with the >> * exact flag set was done. When the invalid count is non-zero >> * in the header written to the stream, the kernel will make >> - * sure that that many HPTEs are invalid, and invalidate them >> + * sure that many HPTEs are invalid, and invalidate them > > You are changing the meaning here. > > The sentence is: > > ... make sure that: that many HPTEs are invalid. > > You changed the meaning to: > > ... make sure that: many HPTEs are invalid. > > > > It doesn't mean the same. Correct. This was also discussed on an identical patch: https://lore.kernel.org/linuxppc-dev/87bktdd6s8.fsf@mpe.ellerman.id.au/ In next I have fixed all genuine occurences of repeated words that I could find, so hopefully we will have fewer of these patches to process from now on. cheers
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 514fd45c1994..73c6db20cd8a 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm, * is valid, it is written to the HPT as if an H_ENTER with the * exact flag set was done. When the invalid count is non-zero * in the header written to the stream, the kernel will make - * sure that that many HPTEs are invalid, and invalidate them + * sure that many HPTEs are invalid, and invalidate them * if not. */
delete the repeated word "that" in comments Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com> --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)