diff mbox series

[-next] powerpc/pseries/vas: Call misc_deregister if sysfs init fails

Message ID 20220511033507.2745992-1-zhengbin13@huawei.com (mailing list archive)
State Accepted
Headers show
Series [-next] powerpc/pseries/vas: Call misc_deregister if sysfs init fails | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 7 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 24 jobs.
snowpatch_ozlabs/github-powerpc_ppctests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_selftests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.

Commit Message

Zheng Bin May 11, 2022, 3:35 a.m. UTC 
Undo effects of misc_register if sysfs init fails after
misc_register.

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 arch/powerpc/platforms/pseries/vas-sysfs.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.31.1

Comments

Michael Ellerman May 24, 2022, 11:09 a.m. UTC | #1 
On Wed, 11 May 2022 11:35:07 +0800, Zheng Bin wrote:
> Undo effects of misc_register if sysfs init fails after
> misc_register.
> 
> 

Applied to powerpc/next.

[1/1] powerpc/pseries/vas: Call misc_deregister if sysfs init fails
      https://git.kernel.org/powerpc/c/426e5805226358dbe9af233347c5bf3c81f2125c

cheers
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/pseries/vas-sysfs.c b/arch/powerpc/platforms/pseries/vas-sysfs.c
index ec65586cbeb3..89ed64d61da7 100644
--- a/arch/powerpc/platforms/pseries/vas-sysfs.c
+++ b/arch/powerpc/platforms/pseries/vas-sysfs.c
@@ -248,6 +248,7 @@  int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps)
 	pseries_vas_kobj = kobject_create_and_add("vas0",
 					&vas_miscdev.this_device->kobj);
 	if (!pseries_vas_kobj) {
+		misc_deregister(&vas_miscdev);
 		pr_err("Failed to create VAS sysfs entry\n");
 		return -ENOMEM;
 	}
@@ -259,6 +260,7 @@  int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps)
 		if (!gzip_caps_kobj) {
 			pr_err("Failed to create VAS GZIP capability entry\n");
 			kobject_put(pseries_vas_kobj);
+			misc_deregister(&vas_miscdev);
 			return -ENOMEM;
 		}
 	}