| Message ID | 20220210202805.7750-4-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | drivers/crypto: Constify static attribute_group | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
Hi Rikard, > The only usage of these is to pass their address to > sysfs_{create,remove}_group(), which takes pointers to const struct > attribute_group. Make them const to allow the compiler to put them in > read-only memory. I checked the file. Indeed, those structs are only used in sysfs_{create,remove}_group. So I agree that they can be constified. They also pass all the automated tests: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220210202805.7750-4-rikard.falkeborn@gmail.com/ Reviewed-by: Daniel Axtens <dja@axtens.net> Kind regards, Daniel > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/crypto/nx/nx-common-pseries.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c > index 4e304f6081e4..7584a34ba88c 100644 > --- a/drivers/crypto/nx/nx-common-pseries.c > +++ b/drivers/crypto/nx/nx-common-pseries.c > @@ -962,7 +962,7 @@ static struct attribute *nx842_sysfs_entries[] = { > NULL, > }; > > -static struct attribute_group nx842_attribute_group = { > +static const struct attribute_group nx842_attribute_group = { > .name = NULL, /* put in device directory */ > .attrs = nx842_sysfs_entries, > }; > @@ -992,7 +992,7 @@ static struct attribute *nxcop_caps_sysfs_entries[] = { > NULL, > }; > > -static struct attribute_group nxcop_caps_attr_group = { > +static const struct attribute_group nxcop_caps_attr_group = { > .name = "nx_gzip_caps", > .attrs = nxcop_caps_sysfs_entries, > }; > -- > 2.35.1
diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c index 4e304f6081e4..7584a34ba88c 100644 --- a/drivers/crypto/nx/nx-common-pseries.c +++ b/drivers/crypto/nx/nx-common-pseries.c @@ -962,7 +962,7 @@ static struct attribute *nx842_sysfs_entries[] = { NULL, }; -static struct attribute_group nx842_attribute_group = { +static const struct attribute_group nx842_attribute_group = { .name = NULL, /* put in device directory */ .attrs = nx842_sysfs_entries, }; @@ -992,7 +992,7 @@ static struct attribute *nxcop_caps_sysfs_entries[] = { NULL, }; -static struct attribute_group nxcop_caps_attr_group = { +static const struct attribute_group nxcop_caps_attr_group = { .name = "nx_gzip_caps", .attrs = nxcop_caps_sysfs_entries, };
The only usage of these is to pass their address to sysfs_{create,remove}_group(), which takes pointers to const struct attribute_group. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/crypto/nx/nx-common-pseries.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)