| Message ID | 20210726154243.29025-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/stacktrace: Include linux/delay.h | expand |
| Related | show |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/snowpatch-0_9_0 | success | Job powerpc/ppctests from runner github |
| snowpatch_ozlabs/snowpatch-0_9_0 | success | Job powerpc/sparse from runner github |
| snowpatch_ozlabs/snowpatch-0_9_0 | success | Job powerpc/clang from runner github |
| snowpatch_ozlabs/github-powerpc_clang | success | Job powerpc/clang from runner github |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Job powerpc/ppctests from runner github |
| snowpatch_ozlabs/github-powerpc_sparse | success | Job powerpc/sparse from runner github |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 25 jobs. |
On Mon, Jul 26, 2021 at 05:42:43PM +0200, Michal Suchanek wrote: > commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") > introduces udelay() call without including the linux/delay.h header. > This may happen to work on master but the header that declares the > functionshould be included nonetheless. > > Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > --- > arch/powerpc/kernel/stacktrace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c > index 2b0d04a1b7d2..a17ac10f86b1 100644 > --- a/arch/powerpc/kernel/stacktrace.c > +++ b/arch/powerpc/kernel/stacktrace.c > @@ -12,6 +12,7 @@ > #include <linux/kallsyms.h> > #include <linux/module.h> > #include <linux/nmi.h> > +#include <linux/delay.h> > #include <linux/sched.h> > #include <linux/sched/debug.h> > #include <linux/sched/task_stack.h> Hmm, I believe we try to keep the list of includes sorted in alphabetical order. Gabriel
diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c index 2b0d04a1b7d2..a17ac10f86b1 100644 --- a/arch/powerpc/kernel/stacktrace.c +++ b/arch/powerpc/kernel/stacktrace.c @@ -12,6 +12,7 @@ #include <linux/kallsyms.h> #include <linux/module.h> #include <linux/nmi.h> +#include <linux/delay.h> #include <linux/sched.h> #include <linux/sched/debug.h> #include <linux/sched/task_stack.h>
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header. This may happen to work on master but the header that declares the functionshould be included nonetheless. Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- arch/powerpc/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+)