| Message ID | 20210408011801.557004-2-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Christophe Leroy |
| Headers | show |
| Series | code optimizations for btext.c | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (571b0d1ccf5cd3dc1b9866a908769ee23f7d127e) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Le 08/04/2021 à 03:18, Yu Kuai a écrit : > Fixes gcc '-Wunused-but-set-variable' warning: > > arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' > defined but not used. You don't get this error as it is now. You will get this error only if you make it 'static', which is what you did in your first patch based on the 'sparse' report. When removing a non static variable, you should explain that you can remove it after you have verifier that it is nowhere used, neither in that file nor in any other one. > > It is never used, and so can be removed. > > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > --- > arch/powerpc/kernel/btext.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c > index 803c2a45b22a..359d0f4ca532 100644 > --- a/arch/powerpc/kernel/btext.c > +++ b/arch/powerpc/kernel/btext.c > @@ -46,7 +46,6 @@ unsigned long disp_BAT[2] __initdata = {0, 0}; > static unsigned char vga_font[cmapsz]; > > int boot_text_mapped __force_data = 0; > -int force_printk_to_btext = 0; > > extern void rmci_on(void); > extern void rmci_off(void); >
On 2021/04/08 13:01, Christophe Leroy wrote: > > > Le 08/04/2021 à 03:18, Yu Kuai a écrit : >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' >> defined but not used. > > You don't get this error as it is now. > You will get this error only if you make it 'static', which is what you > did in your first patch based on the 'sparse' report. > > When removing a non static variable, you should explain that you can > remove it after you have verifier that it is nowhere used, neither in > that file nor in any other one. Hi, I do use 'git grep force_printk_to_btext' to confirm that 'force_printk_to_btext' is not used anywhere. Maybe it's better to metion it in commit message? Thanks Yu Kuai > >> >> It is never used, and so can be removed. >> >> Signed-off-by: Yu Kuai <yukuai3@huawei.com> >> --- >> arch/powerpc/kernel/btext.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c >> index 803c2a45b22a..359d0f4ca532 100644 >> --- a/arch/powerpc/kernel/btext.c >> +++ b/arch/powerpc/kernel/btext.c >> @@ -46,7 +46,6 @@ unsigned long disp_BAT[2] __initdata = {0, 0}; >> static unsigned char vga_font[cmapsz]; >> int boot_text_mapped __force_data = 0; >> -int force_printk_to_btext = 0; >> extern void rmci_on(void); >> extern void rmci_off(void); >> > . >
diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index 803c2a45b22a..359d0f4ca532 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -46,7 +46,6 @@ unsigned long disp_BAT[2] __initdata = {0, 0}; static unsigned char vga_font[cmapsz]; int boot_text_mapped __force_data = 0; -int force_printk_to_btext = 0; extern void rmci_on(void); extern void rmci_off(void);
Fixes gcc '-Wunused-but-set-variable' warning: arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' defined but not used. It is never used, and so can be removed. Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- arch/powerpc/kernel/btext.c | 1 - 1 file changed, 1 deletion(-)