| Message ID | 20201214080121.358567-1-aneesh.kumar@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 44b4c4450f8d31296ba633d74be753a85fd627bd |
| Headers | show |
| Series | [v2] powerpc/book3s/kup: Mark the kuap/keup function non __init | expand |
> On 14-Dec-2020, at 1:31 PM, Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> wrote: > > The kernel call these functions on cpu online and hence they should > not be marked __init. > > Fixes: 3b47b7549ead ("powerpc/book3s64/kuap: Move KUAP related function outside radix") > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > — This fixes the reported crash I ran into during a cpu online operation. Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> -Sachin
On Mon, 14 Dec 2020 13:31:21 +0530, Aneesh Kumar K.V wrote: > The kernel call these functions on cpu online and hence they should > not be marked __init. Applied to powerpc/next. [1/1] powerpc/64s: Mark the kuap/kuep functions non __init https://git.kernel.org/powerpc/c/44b4c4450f8d31296ba633d74be753a85fd627bd cheers
diff --git a/arch/powerpc/mm/book3s64/pkeys.c b/arch/powerpc/mm/book3s64/pkeys.c index 2b7ded396db4..f1c6f264ed91 100644 --- a/arch/powerpc/mm/book3s64/pkeys.c +++ b/arch/powerpc/mm/book3s64/pkeys.c @@ -251,7 +251,7 @@ void __init pkey_early_init_devtree(void) } #ifdef CONFIG_PPC_KUEP -void __init setup_kuep(bool disabled) +void setup_kuep(bool disabled) { if (disabled) return; @@ -277,7 +277,7 @@ void __init setup_kuep(bool disabled) #endif #ifdef CONFIG_PPC_KUAP -void __init setup_kuap(bool disabled) +void setup_kuap(bool disabled) { if (disabled) return;
The kernel call these functions on cpu online and hence they should not be marked __init. Fixes: 3b47b7549ead ("powerpc/book3s64/kuap: Move KUAP related function outside radix") Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- arch/powerpc/mm/book3s64/pkeys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)