| Message ID | 20200706132302.3885935-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b648a5132ca3237a0f1ce5d871fff342b0efcf8a |
| Headers | show |
| Series | powerpc/spufs: add CONFIG_COREDUMP dependency | expand |
Hi Arnd, > The kernel test robot pointed out a slightly different error message > after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core > dumping") to spufs for a configuration that never worked: > > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in > function `.spufs_proxydma_info_dump': > > > file.c:(.text+0x4c68): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in > function `.spufs_dma_info_dump': > file.c:(.text+0x4d70): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in > function `.spufs_wbox_info_dump': > file.c:(.text+0x4df4): undefined reference to `.dump_emit' > > Add a Kconfig dependency to prevent this from happening again. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Looks good to me, thanks. Acked-by: Jeremy Kerr <jk@ozlabs.org> Cheers, Jeremy
On Mon, 6 Jul 2020 15:22:46 +0200, Arnd Bergmann wrote: > The kernel test robot pointed out a slightly different error message > after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core > dumping") to spufs for a configuration that never worked: > > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump': > >> file.c:(.text+0x4c68): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump': > file.c:(.text+0x4d70): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump': > file.c:(.text+0x4df4): undefined reference to `.dump_emit' > > [...] Applied to powerpc/next. [1/1] powerpc/spufs: add CONFIG_COREDUMP dependency https://git.kernel.org/powerpc/c/b648a5132ca3237a0f1ce5d871fff342b0efcf8a cheers
diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig index 0f7c8241912b..f2ff359041ee 100644 --- a/arch/powerpc/platforms/cell/Kconfig +++ b/arch/powerpc/platforms/cell/Kconfig @@ -44,6 +44,7 @@ config SPU_FS tristate "SPU file system" default m depends on PPC_CELL + depends on COREDUMP select SPU_BASE help The SPU file system is used to access Synergistic Processing
The kernel test robot pointed out a slightly different error message after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core dumping") to spufs for a configuration that never worked: powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump': >> file.c:(.text+0x4c68): undefined reference to `.dump_emit' powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump': file.c:(.text+0x4d70): undefined reference to `.dump_emit' powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump': file.c:(.text+0x4df4): undefined reference to `.dump_emit' Add a Kconfig dependency to prevent this from happening again. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/powerpc/platforms/cell/Kconfig | 1 + 1 file changed, 1 insertion(+)