| Message ID | 20200614083604.302611-1-maddy@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3c9450c053f88e525b2db1e6990cdf34d14e7696 |
| Headers | show |
| Series | powerpc/perf: fix missing is_sier_aviable() during build | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (062ce06f9dcd140b6cd97102fec593a57c5fb397) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch powerpc/merge |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch powerpc/merge |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
On Sun, 14 Jun 2020 14:06:04 +0530, Madhavan Srinivasan wrote: > Compilation error: > > arch/powerpc/perf/perf_regs.c:80:undefined reference to `.is_sier_available' > > Currently is_sier_available() is part of core-book3s.c. > But then, core-book3s.c is added to build based on > CONFIG_PPC_PERF_CTRS. A config with CONFIG_PERF_EVENTS > and without CONFIG_PPC_PERF_CTRS will have a build break > because of missing is_sier_available(). Patch adds > is_sier_available() in asm/perf_event.h to fix the build > break for configs missing CONFIG_PPC_PERF_CTRS. Applied to powerpc/next. [1/1] powerpc/perf: Fix missing is_sier_aviable() during build https://git.kernel.org/powerpc/c/3c9450c053f88e525b2db1e6990cdf34d14e7696 cheers
diff --git a/arch/powerpc/include/asm/perf_event.h b/arch/powerpc/include/asm/perf_event.h index eed3954082fa..1e8b2e1ec1db 100644 --- a/arch/powerpc/include/asm/perf_event.h +++ b/arch/powerpc/include/asm/perf_event.h @@ -12,6 +12,8 @@ #ifdef CONFIG_PPC_PERF_CTRS #include <asm/perf_event_server.h> +#else +static inline bool is_sier_available(void) { return false; } #endif #ifdef CONFIG_FSL_EMB_PERF_EVENT
Compilation error: arch/powerpc/perf/perf_regs.c:80:undefined reference to `.is_sier_available' Currently is_sier_available() is part of core-book3s.c. But then, core-book3s.c is added to build based on CONFIG_PPC_PERF_CTRS. A config with CONFIG_PERF_EVENTS and without CONFIG_PPC_PERF_CTRS will have a build break because of missing is_sier_available(). Patch adds is_sier_available() in asm/perf_event.h to fix the build break for configs missing CONFIG_PPC_PERF_CTRS. Fixes: 333804dc3b7a9 ('powerpc/perf: Update perf_regs structure to include SIER") Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> --- arch/powerpc/include/asm/perf_event.h | 2 ++ 1 file changed, 2 insertions(+)