| Message ID | 20200309085806.155823-15-ravi.bangoria@linux.ibm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc/watchpoint: Preparation for more than one watchpoint | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (ab326587bb5fb91cc97df9b9f48e9e1469f04621) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : > Xmon allows overwriting breakpoints because it's supported by only > one dawr. But with multiple dawrs, overwriting becomes ambiguous > or unnecessary complicated. So let's not allow it. Could we drop this completely (I mean the functionnality, not the patch). Christophe > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/xmon/xmon.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 0ca0d29f99c6..ac18fe3e4295 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -1381,6 +1381,10 @@ bpt_cmds(void) > printf("Hardware data breakpoint not supported on this cpu\n"); > break; > } > + if (dabr.enabled) { > + printf("Couldn't find free breakpoint register\n"); > + break; > + } > mode = 7; > cmd = inchar(); > if (cmd == 'r') >
On 3/17/20 4:40 PM, Christophe Leroy wrote: > > > Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : >> Xmon allows overwriting breakpoints because it's supported by only >> one dawr. But with multiple dawrs, overwriting becomes ambiguous >> or unnecessary complicated. So let's not allow it. > > Could we drop this completely (I mean the functionnality, not the patch). Not sure I follow. Isn't the same thing I'm doing? -Ravi
Le 18/03/2020 à 13:37, Ravi Bangoria a écrit : > > > On 3/17/20 4:40 PM, Christophe Leroy wrote: >> >> >> Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : >>> Xmon allows overwriting breakpoints because it's supported by only >>> one dawr. But with multiple dawrs, overwriting becomes ambiguous >>> or unnecessary complicated. So let's not allow it. >> >> Could we drop this completely (I mean the functionnality, not the patch). > > Not sure I follow. Isn't the same thing I'm doing? > Yes, I think I misunderstood the patch. That seems ok. Christophe
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 0ca0d29f99c6..ac18fe3e4295 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1381,6 +1381,10 @@ bpt_cmds(void) printf("Hardware data breakpoint not supported on this cpu\n"); break; } + if (dabr.enabled) { + printf("Couldn't find free breakpoint register\n"); + break; + } mode = 7; cmd = inchar(); if (cmd == 'r')
Xmon allows overwriting breakpoints because it's supported by only one dawr. But with multiple dawrs, overwriting becomes ambiguous or unnecessary complicated. So let's not allow it. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- arch/powerpc/xmon/xmon.c | 4 ++++ 1 file changed, 4 insertions(+)