| Message ID | 20200226040716.32395-8-jniethe5@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Initial Prefixed Instruction support | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (65b2623f395a4e25ab3ff4cff1c9c7623619a22d) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Jordan Niethe's on February 26, 2020 2:07 pm: > If prefixed instructions are made unavailable by the [H]FSCR, attempting > to use them will cause a facility unavailable exception. Add "PREFIX" to > the facility_strings[]. > > Currently there are no prefixed instructions that are actually emulated > by emulate_instruction() within facility_unavailable_exception(). > However, when caused by a prefixed instructions the SRR1 PREFIXED bit is > set. Prepare for dealing with emulated prefixed instructions by checking > for this bit. > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> Oh you've got it here, I would just squash this together with the first patch. Thanks, Nick
On Wed, Feb 26, 2020 at 5:53 PM Nicholas Piggin <npiggin@gmail.com> wrote: > > Jordan Niethe's on February 26, 2020 2:07 pm: > > If prefixed instructions are made unavailable by the [H]FSCR, attempting > > to use them will cause a facility unavailable exception. Add "PREFIX" to > > the facility_strings[]. > > > > Currently there are no prefixed instructions that are actually emulated > > by emulate_instruction() within facility_unavailable_exception(). > > However, when caused by a prefixed instructions the SRR1 PREFIXED bit is > > set. Prepare for dealing with emulated prefixed instructions by checking > > for this bit. > > > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> > > Oh you've got it here, I would just squash this together with the first > patch. Sure, I'll put them together. When you mentioned a couple more things to do in traps.c, was it just this? Or is there still more to be done adding an FSCR? > > Thanks, > Nick
Jordan Niethe's on February 27, 2020 9:52 am: > On Wed, Feb 26, 2020 at 5:53 PM Nicholas Piggin <npiggin@gmail.com> wrote: >> >> Jordan Niethe's on February 26, 2020 2:07 pm: >> > If prefixed instructions are made unavailable by the [H]FSCR, attempting >> > to use them will cause a facility unavailable exception. Add "PREFIX" to >> > the facility_strings[]. >> > >> > Currently there are no prefixed instructions that are actually emulated >> > by emulate_instruction() within facility_unavailable_exception(). >> > However, when caused by a prefixed instructions the SRR1 PREFIXED bit is >> > set. Prepare for dealing with emulated prefixed instructions by checking >> > for this bit. >> > >> > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> >> >> Oh you've got it here, I would just squash this together with the first >> patch. > Sure, I'll put them together. When you mentioned a couple more things > to do in traps.c, was it just this? Or is there still more to be done > adding an FSCR? Hmm... maybe it's just that one. Thanks, Nick
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index d80b82fc1ae3..cd8b3043c268 100644 --- a/arch/powerpc/kernel/traps.c +++ b/arch/powerpc/kernel/traps.c @@ -1739,6 +1739,7 @@ void facility_unavailable_exception(struct pt_regs *regs) [FSCR_TAR_LG] = "TAR", [FSCR_MSGP_LG] = "MSGP", [FSCR_SCV_LG] = "SCV", + [FSCR_PREFIX_LG] = "PREFIX", }; char *facility = "unknown"; u64 value;
If prefixed instructions are made unavailable by the [H]FSCR, attempting to use them will cause a facility unavailable exception. Add "PREFIX" to the facility_strings[]. Currently there are no prefixed instructions that are actually emulated by emulate_instruction() within facility_unavailable_exception(). However, when caused by a prefixed instructions the SRR1 PREFIXED bit is set. Prepare for dealing with emulated prefixed instructions by checking for this bit. Signed-off-by: Jordan Niethe <jniethe5@gmail.com> --- arch/powerpc/kernel/traps.c | 1 + 1 file changed, 1 insertion(+)