| Message ID | 20191223133147.129983-1-Jason@zx2c4.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6da3eced8c5f3b03340b0c395bacd552c4d52411 |
| Headers | show |
| Series | powerpc/shared: include correct header for static key | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (2a6c9161d9de88960a122cf33295228ebbcf852f) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
On Mon, 2019-12-23 at 13:31:47 UTC, "Jason A. Donenfeld" wrote: > Recently, the spinlock implementation grew a static key optimization, > but the jump_label.h header include was left out, leading to build > errors: > > linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] > 44 | if (!static_branch_unlikely(&shared_processor)) > > This commit adds the missing header. > > Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor") > Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/6da3eced8c5f3b03340b0c395bacd552c4d52411 cheers
diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h index 1b55fc08f853..860228e917dc 100644 --- a/arch/powerpc/include/asm/spinlock.h +++ b/arch/powerpc/include/asm/spinlock.h @@ -15,6 +15,7 @@ * * (the type definitions are in asm/spinlock_types.h) */ +#include <linux/jump_label.h> #include <linux/irqflags.h> #ifdef CONFIG_PPC64 #include <asm/paca.h>
Recently, the spinlock implementation grew a static key optimization, but the jump_label.h header include was left out, leading to build errors: linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration] 44 | if (!static_branch_unlikely(&shared_processor)) This commit adds the missing header. Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor") Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> --- arch/powerpc/include/asm/spinlock.h | 1 + 1 file changed, 1 insertion(+)