| Message ID | 20190802000835.26191-1-jniethe5@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1ebe0dcce1750109181d666394b7dfd9af9ff645 |
| Headers | show |
| Series | powerpc/xive: Update comment referencing magic loads from an ESB | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f3365d1a959d5c6527efe3d38276acc9b58e3f3f) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
Jordan Niethe <jniethe5@gmail.com> writes: > The comment above xive_esb_read() references magic loads from an ESB as > described xive.h. This has been inaccurate since commit 12c1f339cd49 > ("powerpc/xive: Move definition of ESB bits") which moved the > description. Update the comment to reference the new location of the > description in xive-regs.h > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> Acked-by: Stewart Smith <stewart@linux.ibm.com>
On Fri, 2019-08-02 at 00:08:35 UTC, Jordan Niethe wrote: > The comment above xive_esb_read() references magic loads from an ESB as > described xive.h. This has been inaccurate since commit 12c1f339cd49 > ("powerpc/xive: Move definition of ESB bits") which moved the > description. Update the comment to reference the new location of the > description in xive-regs.h > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> > Acked-by: Stewart Smith <stewart@linux.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1ebe0dcce1750109181d666394b7dfd9af9ff645 cheers
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c index 1cdb39575eae..083f657091d7 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -185,7 +185,7 @@ static u32 xive_scan_interrupts(struct xive_cpu *xc, bool just_peek) /* * This is used to perform the magic loads from an ESB - * described in xive.h + * described in xive-regs.h */ static notrace u8 xive_esb_read(struct xive_irq_data *xd, u32 offset) {
The comment above xive_esb_read() references magic loads from an ESB as described xive.h. This has been inaccurate since commit 12c1f339cd49 ("powerpc/xive: Move definition of ESB bits") which moved the description. Update the comment to reference the new location of the description in xive-regs.h Signed-off-by: Jordan Niethe <jniethe5@gmail.com> --- arch/powerpc/sysdev/xive/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)