| Message ID | 20190618042732.5582-2-ravi.bangoria@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Powerpc/hw-breakpoint: Fixes plus Code refactor | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (e610a466d16a086e321f0bd421e2fc75cff28605) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
> Subject: Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Can you add the word "comment" to this subject. Currently it implies there are code changes here. Mikey On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: > do_dabr() was renamed with do_break() long ago. But I still see > some comments mentioning do_dabr(). Replace it. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 +- > arch/powerpc/kernel/ptrace.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/hw_breakpoint.c > b/arch/powerpc/kernel/hw_breakpoint.c > index a293a53b4365..1908e4fcc132 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) > * Return early after invoking user-callback function without restoring > * DABR if the breakpoint is from ptrace which always operates in > * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal > - * generated in do_dabr(). > + * generated in do_break(). > */ > if (bp->overflow_handler == ptrace_triggered) { > perf_bp_event(bp, regs); > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index 684b0b315c32..44b823e5e8c8 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, > /* > * Disable the breakpoint request here since ptrace has defined a > * one-shot behaviour for breakpoint exceptions in PPC64. > - * The SIGTRAP signal is generated automatically for us in do_dabr(). > + * The SIGTRAP signal is generated automatically for us in do_break(). > * We don't have to do anything about that here > */ > attr = bp->attr;
The subject text should mention you are changing comments. Here it suggests you are changing code text. Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : > do_dabr() was renamed with do_break() long ago. But I still see > some comments mentioning do_dabr(). Replace it. s/Replace it/Replace them/ Christophe > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 +- > arch/powerpc/kernel/ptrace.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c > index a293a53b4365..1908e4fcc132 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) > * Return early after invoking user-callback function without restoring > * DABR if the breakpoint is from ptrace which always operates in > * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal > - * generated in do_dabr(). > + * generated in do_break(). > */ > if (bp->overflow_handler == ptrace_triggered) { > perf_bp_event(bp, regs); > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index 684b0b315c32..44b823e5e8c8 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, > /* > * Disable the breakpoint request here since ptrace has defined a > * one-shot behaviour for breakpoint exceptions in PPC64. > - * The SIGTRAP signal is generated automatically for us in do_dabr(). > + * The SIGTRAP signal is generated automatically for us in do_break(). > * We don't have to do anything about that here > */ > attr = bp->attr; >
diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index a293a53b4365..1908e4fcc132 100644 --- a/arch/powerpc/kernel/hw_breakpoint.c +++ b/arch/powerpc/kernel/hw_breakpoint.c @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) * Return early after invoking user-callback function without restoring * DABR if the breakpoint is from ptrace which always operates in * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal - * generated in do_dabr(). + * generated in do_break(). */ if (bp->overflow_handler == ptrace_triggered) { perf_bp_event(bp, regs); diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c index 684b0b315c32..44b823e5e8c8 100644 --- a/arch/powerpc/kernel/ptrace.c +++ b/arch/powerpc/kernel/ptrace.c @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, /* * Disable the breakpoint request here since ptrace has defined a * one-shot behaviour for breakpoint exceptions in PPC64. - * The SIGTRAP signal is generated automatically for us in do_dabr(). + * The SIGTRAP signal is generated automatically for us in do_break(). * We don't have to do anything about that here */ attr = bp->attr;
do_dabr() was renamed with do_break() long ago. But I still see some comments mentioning do_dabr(). Replace it. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- arch/powerpc/kernel/hw_breakpoint.c | 2 +- arch/powerpc/kernel/ptrace.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)