diff mbox series

[5/5] powerpc/64s: Document that PPC supports nosmap

Message ID 20181026063513.30806-6-ruscur@russell.cc (mailing list archive)
State Superseded
Headers show
Series Guarded Userspace Access Prevention on Radix | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success next/apply_patch Successfully applied
snowpatch_ozlabs/checkpatch warning Test checkpatch on branch next
snowpatch_ozlabs/build-ppc64le warning Test build-ppc64le on branch next
snowpatch_ozlabs/build-ppc64be warning Test build-ppc64be on branch next
snowpatch_ozlabs/build-ppc64e fail Test build-ppc64e on branch next
snowpatch_ozlabs/build-ppc32 fail Test build-ppc32 on branch next

Commit Message

Russell Currey Oct. 26, 2018, 6:35 a.m. UTC
Signed-off-by: Russell Currey <ruscur@russell.cc>
---
 Documentation/admin-guide/kernel-parameters.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christophe Leroy Oct. 26, 2018, 4:35 p.m. UTC | #1
Why not call our new functionnality SMAP instead of calling it GUAP ?

Christophe

Russell Currey <ruscur@russell.cc> a écrit :

> Signed-off-by: Russell Currey <ruscur@russell.cc>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt  
> b/Documentation/admin-guide/kernel-parameters.txt
> index a5ad67d5cb16..8f78e75965f0 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2764,7 +2764,7 @@
>  			noexec=on: enable non-executable mappings (default)
>  			noexec=off: disable non-executable mappings
>
> -	nosmap		[X86]
> +	nosmap		[X86,PPC]
>  			Disable SMAP (Supervisor Mode Access Prevention)
>  			even if it is supported by processor.
>
> --
> 2.19.1
Russell Currey Oct. 29, 2018, 1:06 a.m. UTC | #2
On Fri, 2018-10-26 at 18:35 +0200, LEROY Christophe wrote:
> Why not call our new functionnality SMAP instead of calling it GUAP ?

mpe wasn't a fan of using the same terminology as other architectures. 
Having a separate term does avoid some assumptions about how things
work or are implemented, but sharing compatibility with an existing
parameter is nice.

Personally I don't really care too much about the name.

- Russell

> 
> Christophe
> 
> Russell Currey <ruscur@russell.cc> a écrit :
> 
> > Signed-off-by: Russell Currey <ruscur@russell.cc>
> > ---
> >  Documentation/admin-guide/kernel-parameters.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt  
> > b/Documentation/admin-guide/kernel-parameters.txt
> > index a5ad67d5cb16..8f78e75965f0 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -2764,7 +2764,7 @@
> >  			noexec=on: enable non-executable mappings
> > (default)
> >  			noexec=off: disable non-executable mappings
> > 
> > -	nosmap		[X86]
> > +	nosmap		[X86,PPC]
> >  			Disable SMAP (Supervisor Mode Access
> > Prevention)
> >  			even if it is supported by processor.
> > 
> > --
> > 2.19.1
> 
>
Christophe Leroy Oct. 31, 2018, 5:06 p.m. UTC | #3
Russell Currey <ruscur@russell.cc> a écrit :

> On Fri, 2018-10-26 at 18:35 +0200, LEROY Christophe wrote:
>> Why not call our new functionnality SMAP instead of calling it GUAP ?
>
> mpe wasn't a fan of using the same terminology as other architectures.

I don't like too much the word 'guarded' because it means something  
different for powerpc MMUs.

What about something like 'user space access protection' ?

Christophe

> Having a separate term does avoid some assumptions about how things
> work or are implemented, but sharing compatibility with an existing
> parameter is nice.
>
> Personally I don't really care too much about the name.
>
> - Russell
>
>>
>> Christophe
>>
>> Russell Currey <ruscur@russell.cc> a écrit :
>>
>> > Signed-off-by: Russell Currey <ruscur@russell.cc>
>> > ---
>> >  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/admin-guide/kernel-parameters.txt
>> > b/Documentation/admin-guide/kernel-parameters.txt
>> > index a5ad67d5cb16..8f78e75965f0 100644
>> > --- a/Documentation/admin-guide/kernel-parameters.txt
>> > +++ b/Documentation/admin-guide/kernel-parameters.txt
>> > @@ -2764,7 +2764,7 @@
>> >  			noexec=on: enable non-executable mappings
>> > (default)
>> >  			noexec=off: disable non-executable mappings
>> >
>> > -	nosmap		[X86]
>> > +	nosmap		[X86,PPC]
>> >  			Disable SMAP (Supervisor Mode Access
>> > Prevention)
>> >  			even if it is supported by processor.
>> >
>> > --
>> > 2.19.1
>>
>>
diff mbox series

Patch

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index a5ad67d5cb16..8f78e75965f0 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -2764,7 +2764,7 @@ 
 			noexec=on: enable non-executable mappings (default)
 			noexec=off: disable non-executable mappings
 
-	nosmap		[X86]
+	nosmap		[X86,PPC]
 			Disable SMAP (Supervisor Mode Access Prevention)
 			even if it is supported by processor.