| Message ID | 20180214211519.15683-1-malat@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58935176ad17976b7a7f6ea25c0ceb2ca4308a30 |
| Headers | show |
| Series | [v2] powerpc/via-pmu: Fix section mismatch warning | expand |
On 14/02/2018 22:15, Mathieu Malaterre wrote: > Make the struct via_pmu_driver const to avoid following warning: > > WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init() > The variable via_pmu_driver references > the function __init pmu_init() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > Suggested-by: Laurent Vivier <lvivier@redhat.com> > --- > v2: pmu_init() is really an init function, leave __init marker > > drivers/macintosh/via-pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c > index 94c0f3f7df69..fc56c7067732 100644 > --- a/drivers/macintosh/via-pmu.c > +++ b/drivers/macintosh/via-pmu.c > @@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops; > static const struct file_operations pmu_options_proc_fops; > > #ifdef CONFIG_ADB > -struct adb_driver via_pmu_driver = { > +const struct adb_driver via_pmu_driver = { > "PMU", > pmu_probe, > pmu_init, > Reviewed-by: Laurent Vivier <lvivier@redhat.com>
On Wed, 2018-02-14 at 21:15:18 UTC, Mathieu Malaterre wrote: > Make the struct via_pmu_driver const to avoid following warning: > > WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init() > The variable via_pmu_driver references > the function __init pmu_init() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > Suggested-by: Laurent Vivier <lvivier@redhat.com> > Reviewed-by: Laurent Vivier <lvivier@redhat.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/58935176ad17976b7a7f6ea25c0ceb cheers
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index 94c0f3f7df69..fc56c7067732 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops; static const struct file_operations pmu_options_proc_fops; #ifdef CONFIG_ADB -struct adb_driver via_pmu_driver = { +const struct adb_driver via_pmu_driver = { "PMU", pmu_probe, pmu_init,
Make the struct via_pmu_driver const to avoid following warning: WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init() The variable via_pmu_driver references the function __init pmu_init() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Mathieu Malaterre <malat@debian.org> Suggested-by: Laurent Vivier <lvivier@redhat.com> --- v2: pmu_init() is really an init function, leave __init marker drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)