| Message ID | 20171226130020.23626-1-malat@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 38833faa112c10dd6e3d888f8b53de2b80cb881a |
| Headers | show |
| Series | powerpc/xive: Properly use static keyword for inline function | expand |
On 12/26/2017 02:00 PM, Mathieu Malaterre wrote: > Fix fatal warning during compilation: > > In file included from arch/powerpc/xmon/xmon.c:54:0: > ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes] > extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > ^ > > Signed-off-by: Mathieu Malaterre <malat@debian.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > arch/powerpc/include/asm/xive.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h > index 371fbebf1ec9..83dc2cc320a3 100644 > --- a/arch/powerpc/include/asm/xive.h > +++ b/arch/powerpc/include/asm/xive.h > @@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; } > static inline bool xive_spapr_init(void) { return false; } > static inline bool xive_native_init(void) { return false; } > static inline void xive_smp_probe(void) { } > -extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > +static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > static inline void xive_smp_setup_cpu(void) { } > static inline void xive_smp_disable_cpu(void) { } > static inline void xive_kexec_teardown_cpu(int secondary) { } >
On Tue, 2017-12-26 at 13:00:17 UTC, Mathieu Malaterre wrote: > Fix fatal warning during compilation: > > In file included from arch/powerpc/xmon/xmon.c:54:0: > ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes] > extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } > ^ > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > Reviewed-by: Cédric Le Goater <clg@kaod.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/38833faa112c10dd6e3d888f8b53de cheers
diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h index 371fbebf1ec9..83dc2cc320a3 100644 --- a/arch/powerpc/include/asm/xive.h +++ b/arch/powerpc/include/asm/xive.h @@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; } static inline bool xive_spapr_init(void) { return false; } static inline bool xive_native_init(void) { return false; } static inline void xive_smp_probe(void) { } -extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } +static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } static inline void xive_smp_setup_cpu(void) { } static inline void xive_smp_disable_cpu(void) { } static inline void xive_kexec_teardown_cpu(int secondary) { }
Fix fatal warning during compilation: In file included from arch/powerpc/xmon/xmon.c:54:0: ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes] extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; } ^ Signed-off-by: Mathieu Malaterre <malat@debian.org> --- arch/powerpc/include/asm/xive.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)