diff mbox

[2/2] powerpc/powernv: Add more BPF in defconfig

Message ID 20170206025544.3292-2-mikey@neuling.org (mailing list archive)
State Accepted
Headers show

Commit Message

Michael Neuling Feb. 6, 2017, 2:55 a.m. UTC
This enables BCC (https://github.com/iovisor/bcc) on powernv.

This adds 225KB to the vmlinux size.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
 arch/powerpc/configs/powernv_defconfig | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Michael Ellerman Feb. 7, 2017, 12:10 a.m. UTC | #1
Michael Neuling <mikey@neuling.org> writes:

> This enables BCC (https://github.com/iovisor/bcc) on powernv.
>
> This adds 225KB to the vmlinux size.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
>  arch/powerpc/configs/powernv_defconfig | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
> index 7028dbc753..911b43e2c7 100644
> --- a/arch/powerpc/configs/powernv_defconfig
> +++ b/arch/powerpc/configs/powernv_defconfig
> @@ -29,6 +29,7 @@ CONFIG_CGROUP_CPUACCT=y
>  CONFIG_CGROUP_PERF=y
>  CONFIG_USER_NS=y
>  CONFIG_BLK_DEV_INITRD=y
> +CONFIG_BPF_SYSCALL=y
>  # CONFIG_COMPAT_BRK is not set
>  CONFIG_PROFILING=y
>  CONFIG_OPROFILE=y
> @@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
>  # CONFIG_NETFILTER_ADVANCED is not set
>  CONFIG_BRIDGE=m
>  CONFIG_VLAN_8021Q=m
> +CONFIG_NET_SCHED=y
> +CONFIG_NET_CLS_BPF=y
> +CONFIG_NET_CLS_ACT=y
> +CONFIG_NET_ACT_BPF=y

I'm inclined to make these =m.

I assume that would still work for bcc?

cheers
Naveen N. Rao Feb. 7, 2017, 7:54 a.m. UTC | #2
On 2017/02/07 11:10AM, Michael Ellerman wrote:
> Michael Neuling <mikey@neuling.org> writes:
> 
> > This enables BCC (https://github.com/iovisor/bcc) on powernv.
> >
> > This adds 225KB to the vmlinux size.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > ---
> >  arch/powerpc/configs/powernv_defconfig | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
> > index 7028dbc753..911b43e2c7 100644
> > --- a/arch/powerpc/configs/powernv_defconfig
> > +++ b/arch/powerpc/configs/powernv_defconfig
> > @@ -29,6 +29,7 @@ CONFIG_CGROUP_CPUACCT=y
> >  CONFIG_CGROUP_PERF=y
> >  CONFIG_USER_NS=y
> >  CONFIG_BLK_DEV_INITRD=y
> > +CONFIG_BPF_SYSCALL=y
> >  # CONFIG_COMPAT_BRK is not set
> >  CONFIG_PROFILING=y
> >  CONFIG_OPROFILE=y
> > @@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
> >  # CONFIG_NETFILTER_ADVANCED is not set
> >  CONFIG_BRIDGE=m
> >  CONFIG_VLAN_8021Q=m
> > +CONFIG_NET_SCHED=y
> > +CONFIG_NET_CLS_BPF=y
> > +CONFIG_NET_CLS_ACT=y
> > +CONFIG_NET_ACT_BPF=y
> 
> I'm inclined to make these =m.
> 
> I assume that would still work for bcc?

Yes, that should work too.
As an aside, I had sent a patch to enable BPF_SYSCALL across powernv, 
pseries and ppc64 defconfigs:
https://patchwork.ozlabs.org/patch/721997/

It would be good to have the network related BPF configs enabled across 
all three.

- Naveen
Michael Ellerman Feb. 7, 2017, 11 a.m. UTC | #3
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
> On 2017/02/07 11:10AM, Michael Ellerman wrote:
>> Michael Neuling <mikey@neuling.org> writes:
>> > diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
>> > index 7028dbc753..911b43e2c7 100644
>> > --- a/arch/powerpc/configs/powernv_defconfig
>> > +++ b/arch/powerpc/configs/powernv_defconfig
>> > @@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
>> >  # CONFIG_NETFILTER_ADVANCED is not set
>> >  CONFIG_BRIDGE=m
>> >  CONFIG_VLAN_8021Q=m
>> > +CONFIG_NET_SCHED=y
>> > +CONFIG_NET_CLS_BPF=y
>> > +CONFIG_NET_CLS_ACT=y
>> > +CONFIG_NET_ACT_BPF=y
>> 
>> I'm inclined to make these =m.
>> 
>> I assume that would still work for bcc?
>
> Yes, that should work too.

> As an aside, I had sent a patch to enable BPF_SYSCALL across powernv, 
> pseries and ppc64 defconfigs:
> https://patchwork.ozlabs.org/patch/721997/

Thanks. That's better.

> It would be good to have the network related BPF configs enabled across 
> all three.

I'll mush the patches all together and turn them all on across
pseries/ppc64/powernv.

cheers
diff mbox

Patch

diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
index 7028dbc753..911b43e2c7 100644
--- a/arch/powerpc/configs/powernv_defconfig
+++ b/arch/powerpc/configs/powernv_defconfig
@@ -29,6 +29,7 @@  CONFIG_CGROUP_CPUACCT=y
 CONFIG_CGROUP_PERF=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
@@ -79,6 +80,10 @@  CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=y
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=y
 CONFIG_BPF_JIT=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y