From patchwork Sun Jul 12 22:02:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 494188 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AE8EA1402AA for ; Mon, 13 Jul 2015 08:07:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=iQS6rQ90; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 82F0D1A127F for ; Mon, 13 Jul 2015 08:07:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=iQS6rQ90; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CAA0C1A0429 for ; Mon, 13 Jul 2015 08:02:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=iQS6rQ90; dkim-atps=neutral Received: by ietj16 with SMTP id j16so51102311iet.0 for ; Sun, 12 Jul 2015 15:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=HUOzm81gXDUFMUCVjOKlh//uL1flnRxJxETARgOFxb0=; b=iQS6rQ90G5X7KEj2pvi1IiHXhLGdaAkJ+iOd29EirJ+64WQWxidiH+dSZpq67m53xz HadszXnFysIn+y6bxcc2pYMTzppEpSmT52yi2ie7xJrYP3BDEikw5UAKUxkCjqDscDLV KAXI5AweacDfsGEAIQRxB2+xj1RDbAUiP5VPRwFwEh+r71EBTzHH/2Yp6wMhWUQ21k0M EWU124+KC566v1lOJeaHGxtocXuo72/4AQ11aaL4UlfpatZBc9M1KM8FJu4+IXECRUFf 3PdlvcViGR6toZXB0SJJpFXtn4tKWmr3adAVgpZMIPwcIbwXoTLCs+1s2cN0369KpdiS mPkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=HUOzm81gXDUFMUCVjOKlh//uL1flnRxJxETARgOFxb0=; b=gcy/TA5XXf7AORDAfDQfV9jFwAALYZphPaao3muevN3vA7sFTNaiGPJhfXOpC7LZxY tDX2fuDIncw5tM8Q3bBV+qH4kFOx+BMh2ck1wyWrPXHeA4mkYMlbuVAymtq6ThZNjcYB POPayNDXgx7vrxm9zroP/tD64Kyb+zWfCnA1s2kQMqY/hd690i97KWs3+qVOpxvI6vLn DhprvOt1eIU5Nbrktas1yQrHFe30sJ2NOAo/FZjAtQJeyyz5eOsuKcyNiL+U78jIp061 PRERYYj9ATxvmnJ59oFSUls5ZstG+KbqYKTI2pDYgiQSmxC5ELRq7zYuj2gPkvZBTt+J WfPg== X-Gm-Message-State: ALoCoQnC7TZJq+SOa6y/y6BgEobctT7ZBTPGT72MaR6XnEzcNcIbGGcqa+XtfAIodAs6pY/qW0n+ X-Received: by 10.107.166.136 with SMTP id p130mr17625202ioe.163.1436738526001; Sun, 12 Jul 2015 15:02:06 -0700 (PDT) Received: from localhost ([69.71.1.1]) by smtp.gmail.com with ESMTPSA id b140sm11286613ioe.9.2015.07.12.15.02.04 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 12 Jul 2015 15:02:04 -0700 (PDT) Subject: [PATCH 2/3] x86, irq: Clarify "No irq handler" message To: Thomas Gleixner From: Bjorn Helgaas Date: Sun, 12 Jul 2015 17:02:02 -0500 Message-ID: <20150712220202.7166.22099.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20150712215559.7166.33068.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20150712215559.7166.33068.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Previously we printed, e.g., do_IRQ: 0.242 No irq handler for vector (irq -1) There's no clue about what "0.242" means, and the IRQ number, which is the important generic information used by drivers and /proc/interrupts, is almost an afterthought. Change the format to this: No handler for IRQ -1 (CPU 0 vector 0xf2) Signed-off-by: Bjorn Helgaas --- arch/x86/kernel/irq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 2949c6e..3c6b069 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -224,9 +224,8 @@ __visible unsigned int __irq_entry do_IRQ(struct pt_regs *regs) ack_APIC_irq(); if (irq != IRQ_RETRIGGERED) { - pr_emerg_ratelimited("%s: %d.%d No irq handler for vector (irq %d)\n", - __func__, smp_processor_id(), - vector, irq); + pr_emerg_ratelimited("No handler for IRQ %d (CPU %d vector %#x)\n", + irq, smp_processor_id(), vector); } else { __this_cpu_write(vector_irq[vector], IRQ_UNDEFINED); }