| Message ID | 20150702224119.GF1712@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Am Donnerstag, 2. Juli 2015, 15:41:19 schrieb Nishanth Aravamudan: Hi Nishanth, >Currently, when the nx-842-pseries driver loads, the following message >is emitted: > >alg: No test for 842 (842-nx) > >It seems like the simplest way to fix this message (other than adding a >proper test) is to just insert the null test into the list in the >testmgr. > >Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> > >--- > crypto/testmgr.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/crypto/testmgr.c b/crypto/testmgr.c >index d0a42bd3aae9..ff0f76e0d0b4 100644 >--- a/crypto/testmgr.c >+++ b/crypto/testmgr.c >@@ -1982,6 +1982,9 @@ static int alg_test_null(const struct alg_test_desc >*desc, /* Please keep this list sorted by algorithm name. */ > static const struct alg_test_desc alg_test_descs[] = { > { >+ .alg = "842", >+ .test = alg_test_null, >+ }, { > .alg = "__cbc-cast5-avx", > .test = alg_test_null, As this is a compression algo, it is safe to add fips_allowed = 1 here as otherwise the algo is not available in fips=1 > }, { Ciao Stephan
On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: > Currently, when the nx-842-pseries driver loads, the following message > is emitted: > > alg: No test for 842 (842-nx) > > It seems like the simplest way to fix this message (other than adding a > proper test) is to just insert the null test into the list in the > testmgr. > > Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> Please add some real test vectors instead. Thanks,
On 04.07.2015 [15:24:53 +0800], Herbert Xu wrote: > On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: > > Currently, when the nx-842-pseries driver loads, the following message > > is emitted: > > > > alg: No test for 842 (842-nx) > > > > It seems like the simplest way to fix this message (other than adding a > > proper test) is to just insert the null test into the list in the > > testmgr. > > > > Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> > > Please add some real test vectors instead.
On 13.07.2015 [17:05:36 -0700], Nishanth Aravamudan wrote: > On 04.07.2015 [15:24:53 +0800], Herbert Xu wrote: > > On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: > > > Currently, when the nx-842-pseries driver loads, the following message > > > is emitted: > > > > > > alg: No test for 842 (842-nx) > > > > > > It seems like the simplest way to fix this message (other than adding a > > > proper test) is to just insert the null test into the list in the > > > testmgr. > > > > > > Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> > > > > Please add some real test vectors instead. Apologies, hit send too fast. I'll work with Dan on this when he gets back from vacation. -Nish
On Mon, Jul 13, 2015 at 8:05 PM, Nishanth Aravamudan <nacc@linux.vnet.ibm.com> wrote: > On 13.07.2015 [17:05:36 -0700], Nishanth Aravamudan wrote: >> On 04.07.2015 [15:24:53 +0800], Herbert Xu wrote: >> > On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: >> > > Currently, when the nx-842-pseries driver loads, the following message >> > > is emitted: >> > > >> > > alg: No test for 842 (842-nx) >> > > >> > > It seems like the simplest way to fix this message (other than adding a >> > > proper test) is to just insert the null test into the list in the >> > > testmgr. >> > > >> > > Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> >> > >> > Please add some real test vectors instead. > > Apologies, hit send too fast. I'll work with Dan on this when he gets > back from vacation. Back from vacation! :-) I originally didn't add any test vector for NX 842 because the main driver was loading before the "platform" (pseries/powernv) drivers, and the test couldn't run as the platform driver hadn't loaded yet. That's now fixed so we should be able to add a real test for NX 842 now, I can work on that patch. > > -Nish > > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/crypto/testmgr.c b/crypto/testmgr.c index d0a42bd3aae9..ff0f76e0d0b4 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -1982,6 +1982,9 @@ static int alg_test_null(const struct alg_test_desc *desc, /* Please keep this list sorted by algorithm name. */ static const struct alg_test_desc alg_test_descs[] = { { + .alg = "842", + .test = alg_test_null, + }, { .alg = "__cbc-cast5-avx", .test = alg_test_null, }, {
Currently, when the nx-842-pseries driver loads, the following message is emitted: alg: No test for 842 (842-nx) It seems like the simplest way to fix this message (other than adding a proper test) is to just insert the null test into the list in the testmgr. Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> --- crypto/testmgr.c | 3 +++ 1 file changed, 3 insertions(+)