| Message ID | 20141125161006.1995.31789.stgit@bahia.lab.toulouse-stg.fr.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 221195fb80daa1a0c2fd54a023081c416fe93340 |
| Delegated to: | Michael Ellerman |
| Headers | show |
On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote: >This is what we get in dmesg when booting a pseries guest and >the hypervisor doesn't provide EEH support. > >[ 0.166655] EEH functionality not supported >[ 0.166778] eeh_init: Failed to call platform init function (-22) > >Since both powernv_eeh_init() and pseries_eeh_init() already complain when >hitting an error, it is not needed to print more (especially such an >uninformative message). > >Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Thanks, Gavin >--- > arch/powerpc/kernel/eeh.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c >index 2248a19..7d62018 100644 >--- a/arch/powerpc/kernel/eeh.c >+++ b/arch/powerpc/kernel/eeh.c >@@ -920,11 +920,8 @@ int eeh_init(void) > pr_warn("%s: Platform EEH operation not found\n", > __func__); > return -EEXIST; >- } else if ((ret = eeh_ops->init())) { >- pr_warn("%s: Failed to call platform init function (%d)\n", >- __func__, ret); >+ } else if ((ret = eeh_ops->init())) > return ret; >- } > > /* Initialize EEH event */ > ret = eeh_event_init(); > >_______________________________________________ >Linuxppc-dev mailing list >Linuxppc-dev@lists.ozlabs.org >https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, 26 Nov 2014 09:28:47 +1100 Gavin Shan <gwshan@linux.vnet.ibm.com> wrote: > On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote: > >This is what we get in dmesg when booting a pseries guest and > >the hypervisor doesn't provide EEH support. > > > >[ 0.166655] EEH functionality not supported > >[ 0.166778] eeh_init: Failed to call platform init function (-22) > > > >Since both powernv_eeh_init() and pseries_eeh_init() already complain when > >hitting an error, it is not needed to print more (especially such an > >uninformative message). > > > >Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> > > Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > > Thanks, > Gavin > Ping ? > >--- > > arch/powerpc/kernel/eeh.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > >diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > >index 2248a19..7d62018 100644 > >--- a/arch/powerpc/kernel/eeh.c > >+++ b/arch/powerpc/kernel/eeh.c > >@@ -920,11 +920,8 @@ int eeh_init(void) > > pr_warn("%s: Platform EEH operation not found\n", > > __func__); > > return -EEXIST; > >- } else if ((ret = eeh_ops->init())) { > >- pr_warn("%s: Failed to call platform init function (%d)\n", > >- __func__, ret); > >+ } else if ((ret = eeh_ops->init())) > > return ret; > >- } > > > > /* Initialize EEH event */ > > ret = eeh_event_init(); > > > >_______________________________________________ > >Linuxppc-dev mailing list > >Linuxppc-dev@lists.ozlabs.org > >https://lists.ozlabs.org/listinfo/linuxppc-dev > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote: >On Wed, 26 Nov 2014 09:28:47 +1100 >Gavin Shan <gwshan@linux.vnet.ibm.com> wrote: >> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote: >> >This is what we get in dmesg when booting a pseries guest and >> >the hypervisor doesn't provide EEH support. >> > >> >[ 0.166655] EEH functionality not supported >> >[ 0.166778] eeh_init: Failed to call platform init function (-22) >> > >> >Since both powernv_eeh_init() and pseries_eeh_init() already complain when >> >hitting an error, it is not needed to print more (especially such an >> >uninformative message). >> > >> >Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> >> >> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> >> >> Thanks, >> Gavin >> > >Ping ? > It's already in Michael's git tree. shangw@shangw:~/sandbox/linux.ppc$ git remote -v origin git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux.git (fetch) origin git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux.git (push) shangw@shangw:~/sandbox/linux.ppc$ git branch master * next shangw@shangw:~/sandbox/linux.ppc$ git log --author="Greg Kurz" --oneline 1 221195f powerpc: Drop useless warning in eeh_init() Thanks, Gavin >> >--- >> > arch/powerpc/kernel/eeh.c | 5 +---- >> > 1 file changed, 1 insertion(+), 4 deletions(-) >> > >> >diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c >> >index 2248a19..7d62018 100644 >> >--- a/arch/powerpc/kernel/eeh.c >> >+++ b/arch/powerpc/kernel/eeh.c >> >@@ -920,11 +920,8 @@ int eeh_init(void) >> > pr_warn("%s: Platform EEH operation not found\n", >> > __func__); >> > return -EEXIST; >> >- } else if ((ret = eeh_ops->init())) { >> >- pr_warn("%s: Failed to call platform init function (%d)\n", >> >- __func__, ret); >> >+ } else if ((ret = eeh_ops->init())) >> > return ret; >> >- } >> > >> > /* Initialize EEH event */ >> > ret = eeh_event_init(); >> > >> >_______________________________________________ >> >Linuxppc-dev mailing list >> >Linuxppc-dev@lists.ozlabs.org >> >https://lists.ozlabs.org/listinfo/linuxppc-dev >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev
On Thu, 2014-12-04 at 09:14 +1100, Gavin Shan wrote: > On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote: > >On Wed, 26 Nov 2014 09:28:47 +1100 > >Gavin Shan <gwshan@linux.vnet.ibm.com> wrote: > >> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote: > >> >This is what we get in dmesg when booting a pseries guest and > >> >the hypervisor doesn't provide EEH support. > > > >Ping ? > > It's already in Michael's git tree. Indeed. It's also marked as "Under Review" in patchwork, which basically means I've seen it and it's on its way into my tree unless you hear otherwise. http://patchwork.ozlabs.org/patch/414753/ cheers
On Thu, 04 Dec 2014 11:32:45 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote: > On Thu, 2014-12-04 at 09:14 +1100, Gavin Shan wrote: > > On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote: > > >On Wed, 26 Nov 2014 09:28:47 +1100 > > >Gavin Shan <gwshan@linux.vnet.ibm.com> wrote: > > >> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote: > > >> >This is what we get in dmesg when booting a pseries guest and > > >> >the hypervisor doesn't provide EEH support. > > > > > >Ping ? > > > > It's already in Michael's git tree. > > Indeed. > > It's also marked as "Under Review" in patchwork, which basically means I've > seen it and it's on its way into my tree unless you hear otherwise. > > http://patchwork.ozlabs.org/patch/414753/ > > cheers > > Sorry for the noise, I'll check next time... :\ -- G
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c index 2248a19..7d62018 100644 --- a/arch/powerpc/kernel/eeh.c +++ b/arch/powerpc/kernel/eeh.c @@ -920,11 +920,8 @@ int eeh_init(void) pr_warn("%s: Platform EEH operation not found\n", __func__); return -EEXIST; - } else if ((ret = eeh_ops->init())) { - pr_warn("%s: Failed to call platform init function (%d)\n", - __func__, ret); + } else if ((ret = eeh_ops->init())) return ret; - } /* Initialize EEH event */ ret = eeh_event_init();
This is what we get in dmesg when booting a pseries guest and the hypervisor doesn't provide EEH support. [ 0.166655] EEH functionality not supported [ 0.166778] eeh_init: Failed to call platform init function (-22) Since both powernv_eeh_init() and pseries_eeh_init() already complain when hitting an error, it is not needed to print more (especially such an uninformative message). Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> --- arch/powerpc/kernel/eeh.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)