Message ID | 20120602213452.66ba4cbb@kryten (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Paul Mackerras |
Headers | show |
On Sat, 2012-06-02 at 21:34 +1000, Anton Blanchard wrote: > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to > explicitly-sized type) changed the size of st_nlink on ppc64 from > a long to a short, resulting in boot failures. > > Signed-off-by: Anton Blanchard <anton@samba.org> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Al, did you CC me on that ? I don't remember seeing it but it could be my fault... Cheers, Ben. > --- > > Index: linux-build/arch/powerpc/include/asm/stat.h > =================================================================== > --- linux-build.orig/arch/powerpc/include/asm/stat.h 2012-06-02 21:25:50.322275743 +1000 > +++ linux-build/arch/powerpc/include/asm/stat.h 2012-06-02 21:26:35.183130538 +1000 > @@ -30,7 +30,7 @@ struct stat { > unsigned long st_dev; > ino_t st_ino; > #ifdef __powerpc64__ > - unsigned short st_nlink; > + unsigned long st_nlink; > mode_t st_mode; > #else > mode_t st_mode;
Hi Anton, On Sat, 2 Jun 2012 21:34:52 +1000 Anton Blanchard <anton@samba.org> wrote: > > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to > explicitly-sized type) changed the size of st_nlink on ppc64 from > a long to a short, resulting in boot failures. > > Signed-off-by: Anton Blanchard <anton@samba.org> Would this affect my (early user mode) boot problems reported yesterday; /init: 71: mknod: Permission denied /init: 88: mknod: Permission denied /init: 88: mknod: Permission denied
Hi Stephen, > > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to > > explicitly-sized type) changed the size of st_nlink on ppc64 from > > a long to a short, resulting in boot failures. > > > > Signed-off-by: Anton Blanchard <anton@samba.org> > > Would this affect my (early user mode) boot problems reported > yesterday; > > /init: 71: mknod: Permission denied > /init: 88: mknod: Permission denied > /init: 88: mknod: Permission denied Very similar to the errors I was seeing so I think the patch will fix it. Anton
Hi Anton, On Sun, 3 Jun 2012 13:48:36 +1000 Anton Blanchard <anton@samba.org> wrote: > > > > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to > > > explicitly-sized type) changed the size of st_nlink on ppc64 from > > > a long to a short, resulting in boot failures. > > > > > > Signed-off-by: Anton Blanchard <anton@samba.org> > > > > Would this affect my (early user mode) boot problems reported > > yesterday; > > > > /init: 71: mknod: Permission denied > > /init: 88: mknod: Permission denied > > /init: 88: mknod: Permission denied > > Very similar to the errors I was seeing so I think the patch will fix > it. Great. One less thing to bisect tomorrow :-)
Index: linux-build/arch/powerpc/include/asm/stat.h =================================================================== --- linux-build.orig/arch/powerpc/include/asm/stat.h 2012-06-02 21:25:50.322275743 +1000 +++ linux-build/arch/powerpc/include/asm/stat.h 2012-06-02 21:26:35.183130538 +1000 @@ -30,7 +30,7 @@ struct stat { unsigned long st_dev; ino_t st_ino; #ifdef __powerpc64__ - unsigned short st_nlink; + unsigned long st_nlink; mode_t st_mode; #else mode_t st_mode;
commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to explicitly-sized type) changed the size of st_nlink on ppc64 from a long to a short, resulting in boot failures. Signed-off-by: Anton Blanchard <anton@samba.org> ---