| Message ID | 20090211044854.969CEDDDA9@ozlabs.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
> We have get_vm_area_caller() and __get_vm_area() but not __get_vm_area_caller() > > On powerpc, I use __get_vm_area() to separate the ranges of addresses given > to vmalloc vs. ioremap (various good reasons for that) so in order to be > able to implement the new caller tracking in /proc/vmallocinfo, I need > a "_caller" variant of it. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> It seems reasonable reason and this patch looks good to me :) Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > I want to put into powerpc-next patches relying into that, so if the > patch is ok with you guys, can I stick it in powerpc.git ? hm. Generally, all MM patch should merge into -mm tree at first. but I don't think this patch have conflict risk. Andrew, What do you think?
On Wed, 11 Feb 2009 17:22:47 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > I want to put into powerpc-next patches relying into that, so if the > > patch is ok with you guys, can I stick it in powerpc.git ? > > hm. > Generally, all MM patch should merge into -mm tree at first. > but I don't think this patch have conflict risk. > > Andrew, What do you think? We can sneak it into mainline later in the week?
> On Wed, 11 Feb 2009 17:22:47 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > > I want to put into powerpc-next patches relying into that, so if the > > > patch is ok with you guys, can I stick it in powerpc.git ? > > > > hm. > > Generally, all MM patch should merge into -mm tree at first. > > but I don't think this patch have conflict risk. > > > > Andrew, What do you think? > > We can sneak it into mainline later in the week? I think this patch obiously doesn't have any regression risk. I obey your judgement.
On Wed, 2009-02-11 at 14:45 -0800, Andrew Morton wrote: > On Wed, 11 Feb 2009 17:22:47 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > > I want to put into powerpc-next patches relying into that, so if the > > > patch is ok with you guys, can I stick it in powerpc.git ? > > > > hm. > > Generally, all MM patch should merge into -mm tree at first. > > but I don't think this patch have conflict risk. > > > > Andrew, What do you think? > > We can sneak it into mainline later in the week? That would be best. Cheers, Ben.
--- linux-work.orig/include/linux/vmalloc.h 2009-02-04 15:33:35.000000000 +1100 +++ linux-work/include/linux/vmalloc.h 2009-02-04 15:33:47.000000000 +1100 @@ -84,6 +84,9 @@ extern struct vm_struct *get_vm_area_cal unsigned long flags, void *caller); extern struct vm_struct *__get_vm_area(unsigned long size, unsigned long flags, unsigned long start, unsigned long end); +extern struct vm_struct *__get_vm_area_caller(unsigned long size, unsigned long flags, + unsigned long start, unsigned long end, + void *caller); extern struct vm_struct *get_vm_area_node(unsigned long size, unsigned long flags, int node, gfp_t gfp_mask); Index: linux-work/mm/vmalloc.c =================================================================== --- linux-work.orig/mm/vmalloc.c 2009-02-04 15:32:47.000000000 +1100 +++ linux-work/mm/vmalloc.c 2009-02-04 15:33:25.000000000 +1100 @@ -1106,6 +1106,14 @@ struct vm_struct *__get_vm_area(unsigned } EXPORT_SYMBOL_GPL(__get_vm_area); +struct vm_struct *__get_vm_area_caller(unsigned long size, unsigned long flags, + unsigned long start, unsigned long end, + void *caller) +{ + return __get_vm_area_node(size, flags, start, end, -1, GFP_KERNEL, + caller); +} + /** * get_vm_area - reserve a contiguous kernel virtual area * @size: size of the area
We have get_vm_area_caller() and __get_vm_area() but not __get_vm_area_caller() On powerpc, I use __get_vm_area() to separate the ranges of addresses given to vmalloc vs. ioremap (various good reasons for that) so in order to be able to implement the new caller tracking in /proc/vmallocinfo, I need a "_caller" variant of it. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- I want to put into powerpc-next patches relying into that, so if the patch is ok with you guys, can I stick it in powerpc.git ? include/linux/vmalloc.h | 3 +++ mm/vmalloc.c | 8 ++++++++ 2 files changed, 11 insertions(+)