| Message ID | 20081020121315.10428.10730.stgit@terra (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 0721357d4d04563b6e5c7ffd6b5685df275d5ff9 |
| Headers | show |
On Mon, 2008-10-20 at 08:13 -0400, Jon Smirl wrote: > Format string bug. Not exploitable, as this is only writable by root, > but worth fixing all the same. Where is your signed-off-by ? Cheers, Ben. > See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b > --- > drivers/of/of_i2c.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c > index 6a98dc8..24bbef7 100644 > --- a/drivers/of/of_i2c.c > +++ b/drivers/of/of_i2c.c > @@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap, > > info.addr = *addr; > > - request_module(info.type); > + request_module("%s", info.type); > > result = i2c_new_device(adap, &info); > if (result == NULL) { > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c index 6a98dc8..24bbef7 100644 --- a/drivers/of/of_i2c.c +++ b/drivers/of/of_i2c.c @@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap, info.addr = *addr; - request_module(info.type); + request_module("%s", info.type); result = i2c_new_device(adap, &info); if (result == NULL) {