Message ID | 1873082.m6E4AZmIX5@debian64 (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qrv2L2Bqdz9t40 for <patchwork-incoming@ozlabs.org>; Fri, 22 Apr 2016 21:45:46 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=lists.ozlabs.org header.i=@lists.ozlabs.org header.b=BYtEjIyV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b=gJwvqTrM; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3qrv2L18nwzDqcf for <patchwork-incoming@ozlabs.org>; Fri, 22 Apr 2016 21:45:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.ozlabs.org; s=201601; t=1461325546; bh=E8gdwxMHhAeTLgk+2qFlOX5ieZhZvnJYJieUPpPXbi0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BYtEjIyVLrxNyxIICaTWPgKVJX3Zu82zJ9qigCuWiHYvcIf+lfEBjGJupLQYS7lEF ZuaNZQO1581q12D6mjDD71A1EYtNkuWZb+WQe26jZMnp13qHrJqdOUFisxu+SLRFoE 7P5WCH4AV6XGgmEtH85hMJjXhP528vAPHanvt5DU= X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qrv0k4y49zDq5g for <linuxppc-dev@lists.ozlabs.org>; Fri, 22 Apr 2016 21:44:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b=gJwvqTrM; dkim-atps=neutral Received: by mail-wm0-x241.google.com with SMTP id e201so3568128wme.2 for <linuxppc-dev@lists.ozlabs.org>; Fri, 22 Apr 2016 04:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=AzXfdlji5cFuFywkldwU1J0jlc2oj5pkNcD1QJgg5IU=; b=gJwvqTrMLPNFzgIkUiQuVFD07zGzDuuWnjrA4zaTgTAEq60NcZRd2PuX447Q1lQX2R /AhDYP3dy4psbodQE95mM2oLsI9XdLdOgcZZM1O378Q099yS4nlwU46hpw3XT3t5x9+g A8pjJxrqwd2ckMrVB5C25dIh2I7/pb7eaWfrmsyCNiRySwI3T8KxzVQxjm6lNrkBWY5o PZnsJTksmMzSDoXPNtpft9kjIRB1ZBpBFHbAM/9a5ws4u0W5cEmyUAxuaOHWqEVT/piX r5KxkO0/kCYZp/pIVRD0x+3Fo8LoDaT2ZphZzwmpOYpFPKAx1As/MgShgrqgRgeabI8b Jg3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AzXfdlji5cFuFywkldwU1J0jlc2oj5pkNcD1QJgg5IU=; b=mk/KDm2pFoalZ/OilkNKH5ddEzV1qHfG4azKmBnZfG7jTNeM5Ju97igGtGGmZ5GsXN GgF3q9Nq9fFbNBggvMsyPHVe1WlS+PedwQ2K9pBr21mXnyZ1kNOHqxqw7kQh/qldpxpD 7FrP5R2SouqW0/WOXwLoC4THdri+HsegnDMWGtiBIVsNJPQieQkfu0QSAP+9ib0NLJO7 wH2BhBQLtRrtfVsdzMNm9MOmogJrDb7gXC6MLmnfeIpk8DaXNzd7labFMEwvmcwwIIb+ IHXLJTP4a2lwTgbe3twYfYKPaW2lY3kXcvT8kbpsVq4ZnBUeNWe54VtJRGgTW14+UlXa bHmQ== X-Gm-Message-State: AOPr4FWF4Jqx7kNhLdE9UAFR+EjMQ6rCXplH5AXmNQhirua0Pv8nqvRHujA/biQkTIDEVQ== X-Received: by 10.195.17.166 with SMTP id gf6mr19682692wjd.124.1461325456922; Fri, 22 Apr 2016 04:44:16 -0700 (PDT) Received: from debian64.daheim (p5B2E688B.dip0.t-ipconnect.de. [91.46.104.139]) by smtp.googlemail.com with ESMTPSA id hk7sm7723467wjb.5.2016.04.22.04.44.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Apr 2016 04:44:16 -0700 (PDT) Received: from localhost.daheim ([127.0.0.1] helo=debian64.localnet) by debian64.daheim with esmtps (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.87) (envelope-from <chunkeey@googlemail.com>) id 1atZVP-00053p-LV; Fri, 22 Apr 2016 13:44:15 +0200 To: David Laight <David.Laight@aculab.com> Subject: Re: [PATCH v1 08/23] ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands Date: Fri, 22 Apr 2016 13:44:15 +0200 Message-ID: <1873082.m6E4AZmIX5@debian64> User-Agent: KMail/4.14.10 (Linux/4.6.0-rc3-wt+; KDE/4.14.14; x86_64; ; ) In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F4A7ECF@AcuExch.aculab.com> References: <1461262544-115408-1-git-send-email-andriy.shevchenko@linux.intel.com> <1461262544-115408-9-git-send-email-andriy.shevchenko@linux.intel.com> <063D6719AE5E284EB5DD2968C1650D6D5F4A7ECF@AcuExch.aculab.com> MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>, <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/> List-Post: <mailto:linuxppc-dev@lists.ozlabs.org> List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>, <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe> From: Christian Lamparter via Linuxppc-dev <linuxppc-dev@lists.ozlabs.org> Reply-To: Christian Lamparter <chunkeey@googlemail.com> Cc: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Julian Margetson <runaway@candw.ms>, "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Tejun Heo <tj@kernel.org>, 'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org> |
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 6a61184..67cce54 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1096,12 +1096,9 @@ static unsigned int sata_dwc_qc_issue(struct ata_queued_cmd *qc) ap->ops->sff_tf_load(ap, &qc->tf); sata_dwc_exec_command_by_tag(ap, &qc->tf, tag, SATA_DWC_CMD_ISSUED_PEND); - } else if (ata_is_dma(qc->tf.protocol)) { + return 0; + } else return ata_bmdma_qc_issue(qc); - } else { - return ata_sff_qc_issue(qc); - } - return 0; } static void sata_dwc_error_handler(struct ata_port *ap)