| Message ID | 1613808853-78381-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | powerpc: use ARRAY_SIZE instead of division operation | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (626a6c3d2e20da80aaa710104f34ea6037b28b33) |
| snowpatch_ozlabs/build-ppc64le | fail | Build failed! |
| snowpatch_ozlabs/build-ppc64be | fail | Build failed! |
| snowpatch_ozlabs/build-ppc64e | fail | Build failed! |
| snowpatch_ozlabs/build-pmac32 | fail | Build failed! |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Hi Yang, > This eliminates the following coccicheck warning: > ./arch/powerpc/boot/mktree.c:130:31-32: WARNING: Use ARRAY_SIZE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > arch/powerpc/boot/mktree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/mktree.c b/arch/powerpc/boot/mktree.c > index dc603f3..0b2def5 100644 > --- a/arch/powerpc/boot/mktree.c > +++ b/arch/powerpc/boot/mktree.c > @@ -127,7 +127,7 @@ int main(int argc, char *argv[]) > exit(5); > } > cp = tmpbuf; > - for (i = 0; i < sizeof(tmpbuf) / sizeof(unsigned int); i++) > + for (i = 0; i < ARRAY_SIZE(tmpbuf); i++) Unfortunately this breaks the build - see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1613808853-78381-1-git-send-email-yang.lee@linux.alibaba.com/ This is because 'boot/mktree.c' is a userspace program without access to the usual kernel headers. It might be best to get coccicheck to exclude all of 'arch/powerpc/boot/' as I believe everything in that directory is compiled differently to the rest of the kernel (see the Makefile), but maybe just blacklisting boot/mktree.c would be sufficient. Kind regards, Daniel > cksum += *cp++; > if (write(out_fd, tmpbuf, sizeof(tmpbuf)) != sizeof(tmpbuf)) { > perror("boot-image write"); > -- > 1.8.3.1
diff --git a/arch/powerpc/boot/mktree.c b/arch/powerpc/boot/mktree.c index dc603f3..0b2def5 100644 --- a/arch/powerpc/boot/mktree.c +++ b/arch/powerpc/boot/mktree.c @@ -127,7 +127,7 @@ int main(int argc, char *argv[]) exit(5); } cp = tmpbuf; - for (i = 0; i < sizeof(tmpbuf) / sizeof(unsigned int); i++) + for (i = 0; i < ARRAY_SIZE(tmpbuf); i++) cksum += *cp++; if (write(out_fd, tmpbuf, sizeof(tmpbuf)) != sizeof(tmpbuf)) { perror("boot-image write");
This eliminates the following coccicheck warning: ./arch/powerpc/boot/mktree.c:130:31-32: WARNING: Use ARRAY_SIZE Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/powerpc/boot/mktree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)