| Message ID | 1583454396-1424-1-git-send-email-gromero@linux.ibm.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | KVM: PPC: Book3S HV: Fix typos in comments | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (ab326587bb5fb91cc97df9b9f48e9e1469f04621) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Fri, Mar 06, 2020 at 11:26:36AM +1100, Gustavo Romero wrote: > Fix typos found in comments about the parameter passed > through r5 to kvmppc_{save,restore}_tm_hv functions. Actually "iff" is a common shorthand in some fields and not necessarily a spelling error: https://en.wikipedia.org/wiki/If_and_only_if Gabriel > > Signed-off-by: Gustavo Romero <gromero@linux.ibm.com> > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index dbc2fec..a55dbe8 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -3121,7 +3121,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC) > * Save transactional state and TM-related registers. > * Called with r3 pointing to the vcpu struct and r4 containing > * the guest MSR value. > - * r5 is non-zero iff non-volatile register state needs to be maintained. > + * r5 is non-zero if non-volatile register state needs to be maintained. > * If r5 == 0, this can modify all checkpointed registers, but > * restores r1 and r2 before exit. > */ > @@ -3194,7 +3194,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_P9_TM_XER_SO_BUG) > * Restore transactional state and TM-related registers. > * Called with r3 pointing to the vcpu struct > * and r4 containing the guest MSR value. > - * r5 is non-zero iff non-volatile register state needs to be maintained. > + * r5 is non-zero if non-volatile register state needs to be maintained. > * This potentially modifies all checkpointed registers. > * It restores r1 and r2 from the PACA. > */ > -- > 1.8.3.1 >
Hi Gabriel, On 03/06/2020 01:06 PM, Gabriel Paubert wrote: > On Fri, Mar 06, 2020 at 11:26:36AM +1100, Gustavo Romero wrote: >> Fix typos found in comments about the parameter passed >> through r5 to kvmppc_{save,restore}_tm_hv functions. > > Actually "iff" is a common shorthand in some fields and not necessarily > a spelling error: > > https://en.wikipedia.org/wiki/If_and_only_if I see. Thank you. Best regards, Gustavo
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S index dbc2fec..a55dbe8 100644 --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S @@ -3121,7 +3121,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC) * Save transactional state and TM-related registers. * Called with r3 pointing to the vcpu struct and r4 containing * the guest MSR value. - * r5 is non-zero iff non-volatile register state needs to be maintained. + * r5 is non-zero if non-volatile register state needs to be maintained. * If r5 == 0, this can modify all checkpointed registers, but * restores r1 and r2 before exit. */ @@ -3194,7 +3194,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_P9_TM_XER_SO_BUG) * Restore transactional state and TM-related registers. * Called with r3 pointing to the vcpu struct * and r4 containing the guest MSR value. - * r5 is non-zero iff non-volatile register state needs to be maintained. + * r5 is non-zero if non-volatile register state needs to be maintained. * This potentially modifies all checkpointed registers. * It restores r1 and r2 from the PACA. */
Fix typos found in comments about the parameter passed through r5 to kvmppc_{save,restore}_tm_hv functions. Signed-off-by: Gustavo Romero <gromero@linux.ibm.com> --- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)