| Message ID | 1473189119-29458-4-git-send-email-afleming@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Scott Wood |
| Headers | show |
On 09/06/2016 02:12 PM, Andy Fleming wrote: > This sets up the proper config elements for Power and Reset to work > properly (using the gpio pins). > > Signed-off-by: Andy Fleming <afleming@gmail.com> > --- > arch/powerpc/Makefile | 5 +++++ > arch/powerpc/configs/cyrus_basic_defconfig | 9 +++++++++ > 2 files changed, 14 insertions(+) > create mode 100644 arch/powerpc/configs/cyrus_basic_defconfig Why does cyrus need its own defconfig? Just enable the power/reset stuff in 85xx-hw.config. > +CONFIG_EXT3_FS=y This has nothing to do with power/reset, and is already present in fsl-emb-nonhw.config. -Scott
On Tuesday, September 6, 2016, Scott Wood <scott.wood@nxp.com> wrote: > On 09/06/2016 02:12 PM, Andy Fleming wrote: > > This sets up the proper config elements for Power and Reset to work > > properly (using the gpio pins). > > > > Signed-off-by: Andy Fleming <afleming@gmail.com <javascript:;>> > > --- > > arch/powerpc/Makefile | 5 +++++ > > arch/powerpc/configs/cyrus_basic_defconfig | 9 +++++++++ > > 2 files changed, 14 insertions(+) > > create mode 100644 arch/powerpc/configs/cyrus_basic_defconfig > > Why does cyrus need its own defconfig? Just enable the power/reset > stuff in 85xx-hw.config. > > Ok. > > > > +CONFIG_EXT3_FS=y > > This has nothing to do with power/reset, and is already present in > fsl-emb-nonhw.config. > Ok, weird. Are you sure? I see: > # CONFIG_EXT3_FS is not set > > CONFIG_EXT4_FS=y > > >> >
On 09/10/2016 05:12 PM, Andy Fleming wrote: > > > On Tuesday, September 6, 2016, Scott Wood <scott.wood@nxp.com > <mailto:scott.wood@nxp.com>> wrote: > > On 09/06/2016 02:12 PM, Andy Fleming wrote: > > This sets up the proper config elements for Power and Reset to work > > properly (using the gpio pins). > > > > Signed-off-by: Andy Fleming <afleming@gmail.com <javascript:;>> > > --- > > arch/powerpc/Makefile | 5 +++++ > > arch/powerpc/configs/cyrus_basic_defconfig | 9 +++++++++ > > 2 files changed, 14 insertions(+) > > create mode 100644 arch/powerpc/configs/cyrus_basic_defconfig > > Why does cyrus need its own defconfig? Just enable the power/reset > stuff in 85xx-hw.config. > > > > Ok. Please send non-HTML mail with proper quote markers. It's hard to read when it looks like someone is talking to themself. > > +CONFIG_EXT3_FS=y > > This has nothing to do with power/reset, and is already present in > fsl-emb-nonhw.config. > > > Ok, weird. Are you sure? I see: > > > # CONFIG_EXT3_FS is not set > > CONFIG_EXT4_FS=y Apparently it was just removed by commit bdd910017c6a4 ("powerpc/configs: Remove old symbols from defconfigs"). Andrew Donnellan, why was ext3 support removed? -Scott
Scott Wood <scott.wood@nxp.com> writes: > On 09/10/2016 05:12 PM, Andy Fleming wrote: >> On Tuesday, September 6, 2016, Scott Wood <scott.wood@nxp.com >> <mailto:scott.wood@nxp.com>> wrote: >> On 09/06/2016 02:12 PM, Andy Fleming wrote: >> > +CONFIG_EXT3_FS=y >> >> This has nothing to do with power/reset, and is already present in >> fsl-emb-nonhw.config. >> >> >> Ok, weird. Are you sure? I see: >> >> >> # CONFIG_EXT3_FS is not set >> >> CONFIG_EXT4_FS=y > > Apparently it was just removed by commit > bdd910017c6a4 ("powerpc/configs: Remove old symbols from defconfigs"). > > Andrew Donnellan, why was ext3 support removed? Because ext3 was removed, ext4 handles it now. The EXT3 Kconfig symbols still exist but they are just for backward compat with old configs (like this one), and they just turn on EXT4. So AFAICS Andrew's patch was correct, and you should be getting ext3 support from ext4. cheers
> On Sep 12, 2016, at 18:54, Scott Wood <scott.wood@nxp.com> wrote: > >> On 09/10/2016 05:12 PM, Andy Fleming wrote: >> >> >> On Tuesday, September 6, 2016, Scott Wood <scott.wood@nxp.com >> <mailto:scott.wood@nxp.com>> wrote: >> >>> On 09/06/2016 02:12 PM, Andy Fleming wrote: >>> This sets up the proper config elements for Power and Reset to work >>> properly (using the gpio pins). >>> >>> Signed-off-by: Andy Fleming <afleming@gmail.com <javascript:;>> >>> --- >>> arch/powerpc/Makefile | 5 +++++ >>> arch/powerpc/configs/cyrus_basic_defconfig | 9 +++++++++ >>> 2 files changed, 14 insertions(+) >>> create mode 100644 arch/powerpc/configs/cyrus_basic_defconfig >> >> Why does cyrus need its own defconfig? Just enable the power/reset >> stuff in 85xx-hw.config. >> >> >> >> Ok. > > Please send non-HTML mail with proper quote markers. It's hard to read > when it looks like someone is talking to themself. Argh, sorry. gmail iPhone client did that very subtly. I've flipped it over to Mail, and hopefully that fixes it... Andy
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 1934707..83f257e 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -332,6 +332,11 @@ corenet64_smp_defconfig: $(call merge_into_defconfig,corenet_basic_defconfig,\ 85xx-64bit 85xx-smp altivec 85xx-hw fsl-emb-nonhw) +PHONY += cyrus_defconfig +cyrus_defconfig: + $(call merge_into_defconfig,cyrus_basic_defconfig,\ + 85xx-64bit 85xx-smp altivec 85xx-hw fsl-emb-nonhw) + PHONY += mpc86xx_defconfig mpc86xx_defconfig: $(call merge_into_defconfig,mpc86xx_basic_defconfig,\ diff --git a/arch/powerpc/configs/cyrus_basic_defconfig b/arch/powerpc/configs/cyrus_basic_defconfig new file mode 100644 index 0000000..975150c --- /dev/null +++ b/arch/powerpc/configs/cyrus_basic_defconfig @@ -0,0 +1,9 @@ +CONFIG_CORENET_GENERIC=y +CONFIG_USERLIB=y +CONFIG_GPIO_GENERIC_PLATFORM=y +CONFIG_POWER_SUPPLY=y +CONFIG_POWER_RESET=y +CONFIG_POWER_RESET_GPIO=y +CONFIG_POWER_RESET_GPIO_RESTART=y +CONFIG_RESET_CONTROLLER=y +CONFIG_EXT3_FS=y
This sets up the proper config elements for Power and Reset to work properly (using the gpio pins). Signed-off-by: Andy Fleming <afleming@gmail.com> --- arch/powerpc/Makefile | 5 +++++ arch/powerpc/configs/cyrus_basic_defconfig | 9 +++++++++ 2 files changed, 14 insertions(+) create mode 100644 arch/powerpc/configs/cyrus_basic_defconfig