From patchwork Fri Aug 7 03:18:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Axtens X-Patchwork-Id: 504976 X-Patchwork-Delegate: michael@ellerman.id.au Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 396121402A7 for ; Fri, 7 Aug 2015 13:26:30 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=DRxLg6vP; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 142971A1DF3 for ; Fri, 7 Aug 2015 13:26:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=DRxLg6vP; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 97E921A1D41 for ; Fri, 7 Aug 2015 13:20:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=DRxLg6vP; dkim-atps=neutral Received: by ozlabs.org (Postfix) id 863381401E7; Fri, 7 Aug 2015 13:20:59 +1000 (AEST) Delivered-To: linuxppc-dev@ozlabs.org Received: from mail-pa0-x233.google.com (mail-pa0-x233.google.com [IPv6:2607:f8b0:400e:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1075B1402B0 for ; Fri, 7 Aug 2015 13:20:59 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=DRxLg6vP; dkim-atps=neutral Received: by pawu10 with SMTP id u10so77676306paw.1 for ; Thu, 06 Aug 2015 20:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PWJKx67mhJgKr5ZT3hG+1+H/4mUixS+AJsrcjWgzIJc=; b=DRxLg6vPD8uw7fTqZl6HmlbO0IlzOU6z49jbn/oJnxYxRAEfztndc9OkbpsgiD/wH/ 9BpCs26ypTiuJ+3iUsNlYNHqdvyk2HyMr1TIep1G2RMt0g88ULfbSo2CGRFdtNDcGyfY Y6Xja5unYLydnM+xhT9eYUZs8h4ZQF6ifx00o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PWJKx67mhJgKr5ZT3hG+1+H/4mUixS+AJsrcjWgzIJc=; b=hJjrsYPwkSg11tdwfMOK11FkYL+h6h16BUdfQxoesILdsrypOJdGl/TQug7vnNR1q/ OBmcyhAP3zDfxhNtU9aInD+Qe0zZvbETUmPPQNVd0pO2cZBitBOLTJNMBH0wVxAgAzt6 kZcsXkXSv/tgDfhOjiaLNrJbjNexcqpvodCjFdfUSspDB+Y9PRgWSnw6wfhVZTymIXCZ eG8PJCL7NQT5YhMJnHV7VW4I8FJJG4y9PUjplqFN4Oc0W1jE8Mh3jEZbB7ZHCw1yX59r pNdvqdi8nBexxTD+MYZKGL+MISvaPFljJ8rVqWNTueGtmmx35Zl4tJZ7Ob6KsvhYNWcm aiRw== X-Gm-Message-State: ALoCoQmN1O5Dt5UTPvN4XVUtbiDoVWAWbcAc2MkJ/wcM2AXUuYNdfgIy6DcSMIJpfkAIchLkwYlx X-Received: by 10.68.225.228 with SMTP id rn4mr10049649pbc.25.1438917657404; Thu, 06 Aug 2015 20:20:57 -0700 (PDT) Received: from gamma.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id ss2sm8121681pbc.45.2015.08.06.20.20.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Aug 2015 20:20:56 -0700 (PDT) From: Daniel Axtens To: linuxppc-dev@ozlabs.org Subject: [PATCH 3/4] cxl: sparse: Flag iomem pointers properly Date: Fri, 7 Aug 2015 13:18:19 +1000 Message-Id: <1438917500-12100-3-git-send-email-dja@axtens.net> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1438917500-12100-1-git-send-email-dja@axtens.net> References: <1438917500-12100-1-git-send-email-dja@axtens.net> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, Daniel Axtens , imunsie@au.ibm.com MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Sparse identifies the following address space issues: /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: warning: incorrect type in assignment (different address spaces) /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: expected void volatile [noderef] * /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: got void * /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: warning: incorrect type in assignment (different address spaces) /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: expected void [noderef] *cfg_data /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: got void * Fix those by flagging __iomem in the relevant casts. Signed-off-by: Daniel Axtens Acked-by: Michael Neuling --- drivers/misc/cxl/vphb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index 2eba002b580b..a7b55772a91c 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -122,7 +122,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn, return PCIBIOS_BAD_REGISTER_NUMBER; addr = cxl_pcie_cfg_addr(phb, bus->number, devfn, offset); - *ioaddr = (void *)(addr & ~0x3ULL); + *ioaddr = (void __iomem *)(addr & ~0x3ULL); *shift = ((addr & 0x3) * 8); switch (len) { case 1: @@ -217,7 +217,7 @@ int cxl_pci_vphb_add(struct cxl_afu *afu) /* Setup the PHB using arch provided callback */ phb->ops = &cxl_pcie_pci_ops; phb->cfg_addr = afu->afu_desc_mmio + afu->crs_offset; - phb->cfg_data = (void *)(u64)afu->crs_len; + phb->cfg_data = (void __iomem *)(u64)afu->crs_len; phb->private_data = afu; phb->controller_ops = cxl_pci_controller_ops;