diff mbox

[8/8] powerpc/perf: cleanup in perf_event_print_debug()

Message ID 1434012217-9776-9-git-send-email-maddy@linux.vnet.ibm.com (mailing list archive)
State Rejected
Headers show

Commit Message

maddy June 11, 2015, 8:43 a.m. UTC 
From: Janani <jananive@linux.vnet.ibm.com>

Code cleanup/fix in perf_event_print_debug(). Performance
Monitoring Unit (PMU) registers in the server side
are 64bit long.

Signed-off-by: Janani <jananive@linux.vnet.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/perf/core-book3s.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Ellerman June 25, 2015, 10:37 p.m. UTC | #1 
On Thu, 2015-11-06 at 08:43:37 UTC, Madhavan Srinivasan wrote:
> From: Janani <jananive@linux.vnet.ibm.com>
> 
> Code cleanup/fix in perf_event_print_debug(). Performance
> Monitoring Unit (PMU) registers in the server side
> are 64bit long.

No they're not, see the ISA, figure 17.

cheers
diff mbox

Patch

diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index 4b27caf..36dc23b 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -758,7 +758,7 @@  static void write_pmc(int idx, unsigned long val)
 void perf_event_print_debug(void)
 {
 	unsigned long sdar, sier, flags;
-	u32 pmcs[MAX_HWEVENTS];
+	unsigned long pmcs[MAX_HWEVENTS];
 	int i;
 
 	if (!ppmu->n_counter)
@@ -775,11 +775,11 @@  void perf_event_print_debug(void)
 	for (; i < MAX_HWEVENTS; i++)
 		pmcs[i] = 0xdeadbeef;
 
-	pr_info("PMC1:  %08x PMC2: %08x PMC3: %08x PMC4: %08x\n",
+	pr_info("PMC1:  %016lx PMC2: %016lx PMC3: %016lx PMC4: %016lx\n",
 		 pmcs[0], pmcs[1], pmcs[2], pmcs[3]);
 
 	if (ppmu->n_counter > 4)
-		pr_info("PMC5:  %08x PMC6: %08x PMC7: %08x PMC8: %08x\n",
+		pr_info("PMC5:  %016lx PMC6: %016lx PMC7: %016lx PMC8: %016lx\n",
 			 pmcs[4], pmcs[5], pmcs[6], pmcs[7]);
 
 	pr_info("MMCR0: %016lx MMCR1: %016lx MMCRA: %016lx\n",